Re: RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException

2024-07-15 Thread Rajan Halade
On Thu, 11 Jul 2024 09:51:10 GMT, Fernando Guallini wrote: > The manual test Cipher/DES/PerformanceTest.java fails with > ArithmeticException due to potential division by zero. The issue arises when > calculating the elapsed time using end - start, which could result in zero > milliseconds if

Re: RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException

2024-07-15 Thread Fernando Guallini
On Mon, 15 Jul 2024 08:07:21 GMT, Rajan Halade wrote: >> The manual test Cipher/DES/PerformanceTest.java fails with >> ArithmeticException due to potential division by zero. The issue arises when >> calculating the elapsed time using end - start, which could result in zero >> milliseconds if s

Re: [jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-07-15 Thread Matthew Donovan
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote: > 8324841: PKCS11 tests still skip execution Hello, I still need a reviewer for this small backport. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/19857#issuecomment-2228282469

Re: [jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-07-15 Thread Jaikiran Pai
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote: > 8324841: PKCS11 tests still skip execution This is a clean backport of a test-only fix. Looks good to me for JDK 23. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19857#pullrequestrev

[jdk23] Integrated: 8324841: PKCS11 tests still skip execution

2024-07-15 Thread Matthew Donovan
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote: > 8324841: PKCS11 tests still skip execution This pull request has now been integrated. Changeset: a106e522 Author:Matthew Donovan URL: https://git.openjdk.org/jdk/commit/a106e522f87842b6d63a77bf37a7662a4353ef9e Stats: 2 l

Re: RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

2024-07-15 Thread Matthew Donovan
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan wrote: > In this PR, I updated the version of NSS to 3.101 and removed the test from > the ProblemList for all platforms but linux-ppc64le (that bug is still > outstanding.) > > I also updated the skipTest logic in TestDSAKeyLength.java. Prior

Re: RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

2024-07-15 Thread Jaikiran Pai
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan wrote: > In this PR, I updated the version of NSS to 3.101 and removed the test from > the ProblemList for all platforms but linux-ppc64le (that bug is still > outstanding.) > > I also updated the skipTest logic in TestDSAKeyLength.java. Prior

Re: RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature [v2]

2024-07-15 Thread Matthew Donovan
> In this PR, I updated the version of NSS to 3.101 and removed the test from > the ProblemList for all platforms but linux-ppc64le (that bug is still > outstanding.) > > I also updated the skipTest logic in TestDSAKeyLength.java. Prior to my > change, it compared the version numbers as double

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v9]

2024-07-15 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-07-15 Thread Maurizio Cimadamore
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v4]

2024-07-15 Thread Sean Coffey
> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation > was introduced many years ago. > > Where "ssl" was previously a value to obtain all TLS debug traces (except > network type dumps, verbose data), it now prints only a few lines for a > standard client TLS connectio

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v2]

2024-07-15 Thread Kim Barrett
On Sat, 13 Jul 2024 05:34:24 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>