Re: RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket [v2]

2024-07-09 Thread Prajwal Kumaraswamy
> The client identity checks when "HTTPS" endpoint identification algorithm is > set on SSL server throws "java.security.cert.CertificateException: No subject > alternative names present" when client certificate's SubjectAltName extension > does not match its IP address > > Since the server has

Re: RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket [v2]

2024-07-09 Thread Prajwal Kumaraswamy
On Sat, 6 Jul 2024 00:30:20 GMT, Bradford Wetmore wrote: >> Prajwal Kumaraswamy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> format code with minor changes > > src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java lin

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v5]

2024-07-09 Thread Sean Mullan
On Mon, 8 Jul 2024 20:51:22 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-864 > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull r

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names

2024-07-09 Thread Sean Mullan
On Wed, 3 Jul 2024 15:38:49 GMT, Ben Perez wrote: > 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names Changes requested by mullan (Reviewer). test/jdk/sun/security/util/misc/CurveGetParameterSpec.java line 1: > 1: /* I think a bet

Re: RFR: 8335182: Consolidate and streamline String concat code shapes [v2]

2024-07-09 Thread Andrey Turbanov
On Fri, 28 Jun 2024 12:39:32 GMT, Claes Redestad wrote: >> This PR attains a speed-up on some microbenchmarks by simplifying how we >> build up the MH combinator tree shape >> (only use prependers with prefix, always add a suffix to the newArray >> combinator), then simplifying/inlining some of

Integrated: 8333364: Minor cleanup could be done in com.sun.crypto.provider

2024-07-09 Thread Mark Powers
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-864 This pull request has now been integrated. Changeset: 14721244 Author:Mark Powers URL: https://git.openjdk.org/jdk/commit/1472124489c841642996ae984e21c533ffec8091 Stats: 419 lines i

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v2]

2024-07-09 Thread Ben Perez
> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Deleted test - Changes: - all: https://git.openjdk.org/jdk

Re: RFR: 8335182: Consolidate and streamline String concat code shapes [v3]

2024-07-09 Thread Claes Redestad
> This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the code in the helper > functions. > > Many simple concat

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v3]

2024-07-09 Thread Ben Perez
> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Moved test, clarified error message, explicitly initialized keypair to se