Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-07-03 Thread Sean Mullan
On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-864 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > move variables to above try block The rest of the changes look good to me.

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-07-03 Thread Sean Mullan
On Tue, 2 Jul 2024 17:19:32 GMT, Mark Powers wrote: >> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Poly1305Parameters.java >> line 210: >> >>> 208: HexDumpEncoder encoder = new HexDumpEncoder(); >>> 209: return LINE_SEP + "nonce:" + >>> 210: LINE_

RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names

2024-07-03 Thread Ben Perez
8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names - Commit messages: - Test getParameterSpec returns name not OID - getParameterSpec now returns std name instead of OID Changes: https://git.openjdk.org/jdk/pull/20010/file

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v84]

2024-07-03 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the