Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2]

2024-06-28 Thread duke
On Thu, 27 Jun 2024 15:37:45 GMT, Fernando Guallini wrote: >> The following test: >> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is >> currently marked to be run manually because user inputs are required in the >> console, but instead it can be automated by providing a

Re: RFR: 8335182: Consolidate and streamline String concat code shapes [v2]

2024-06-28 Thread Claes Redestad
> This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the code in the helper > functions. > > Many simple concat

Integrated: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-28 Thread Fernando Guallini
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini wrote: > The following test: > **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is > currently marked to be run manually because user inputs are required in the > console, but instead it can be automated by providing a cus

Re: RFR: 8331163: Consider Trust Settings to select SSL certificate

2024-06-28 Thread Weijun Wang
On Tue, 25 Jun 2024 01:14:05 GMT, Alexey Bakhtin wrote: > Please review a proposal to verify Trust Settings for Keychain key entries. > > Keychain-related Jtreg tests passed. Hi Alexey, sorry I'll be on vacation starting tomorrow and won't be able to review this in 3 weeks. At the mean time, c

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v81]

2024-06-28 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request with a new target base due to a merge or a rebase.

RFR: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile

2024-06-28 Thread Fernando Guallini
There is a compilation issue in the test **test/jdk/sun/security/tools/keytool/NssTest.java** because the [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java) class was moved from keytool/KeyToolTest.java to a library class in th

Re: RFR: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile [v2]

2024-06-28 Thread Fernando Guallini
> There is a compilation issue in the test > **test/jdk/sun/security/tools/keytool/NssTest.java** because the > [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java) > class was moved from keytool/KeyToolTest.java to a library cla

Re: RFR: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile [v2]

2024-06-28 Thread Weijun Wang
On Fri, 28 Jun 2024 16:37:02 GMT, Fernando Guallini wrote: >> There is a compilation issue in the test >> **test/jdk/sun/security/tools/keytool/NssTest.java** because the >> [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java)

Re: RFR: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile [v2]

2024-06-28 Thread Weijun Wang
On Fri, 28 Jun 2024 16:41:00 GMT, Fernando Guallini wrote: >> There is a compilation issue in the test >> **test/jdk/sun/security/tools/keytool/NssTest.java** because the >> [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java)

Re: RFR: 8331163: Consider Trust Settings to select SSL certificate

2024-06-28 Thread Alexey Bakhtin
On Fri, 28 Jun 2024 13:07:55 GMT, Weijun Wang wrote: > Hi Alexey, sorry I'll be on vacation starting tomorrow and won't be able to > review this in 3 weeks. At the mean time, can you try to create a test? > Thanks. Thank you. Will try. - PR Comment: https://git.openjdk.org/jdk/pu

Re: RFR: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile [v2]

2024-06-28 Thread duke
On Fri, 28 Jun 2024 16:41:00 GMT, Fernando Guallini wrote: >> There is a compilation issue in the test >> **test/jdk/sun/security/tools/keytool/NssTest.java** because the >> [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java)

Integrated: 8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile

2024-06-28 Thread Fernando Guallini
On Fri, 28 Jun 2024 16:11:02 GMT, Fernando Guallini wrote: > There is a compilation issue in the test > **test/jdk/sun/security/tools/keytool/NssTest.java** because the > [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java) >

Withdrawn: 8319332: Security properties files inclusion

2024-06-28 Thread duke
On Thu, 2 Nov 2023 19:07:48 GMT, Francisco Ferrari Bihurriet wrote: > The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > orga