Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Sibabrata Sahoo
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-21 Thread Christoph Langer
On Thu, 20 Jun 2024 18:35:00 GMT, Rajan Halade wrote: > Updated all the tests that depend on external infrastructure services as > manual. These tests may fail with external reasons, for instance - change in > CA test portal, certificate status updates, or network issues. Looks good, although

Re: RFR: 8334201: Exclude CAInterop.java#certignarootca

2024-06-21 Thread Christoph Langer
On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote: > The test is failing currently and the JBS issue could not be resolved since > about a month, so let's exclude the test for now. Withdrawing in favor of #19814 ([JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441)).

Withdrawn: 8334201: Exclude CAInterop.java#certignarootca

2024-06-21 Thread Christoph Langer
On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote: > The test is failing currently and the JBS issue could not be resolved since > about a month, so let's exclude the test for now. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk

Integrated: 8333867: SHA3 performance can be improved

2024-06-21 Thread Ferenc Rakoczi
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote: > This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. This pull request has now been integrated. Changeset: 75bea280 Author:Ferenc Rakoczi Committer: Weijun Wang URL:

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 08:15:42 GMT, John Jiang wrote: > > The application calls `getSession()` from the same SSLContext of the > > original connection. > > ... > > The remaining tickets sit on the client if they need them. Some > > applications may choose to resume multiple times to download data

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 09:54:34 GMT, Sibabrata Sahoo wrote: > Just for knowledge: If the client has multiple PSK Identity previously shared > by server and client initiate a PSK resumption of type(psk_dhe_ke) and it > receive a HelloRetryRequest from Server, then should client send the same PSK >

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-21 Thread Rajan Halade
On Fri, 21 Jun 2024 13:10:00 GMT, Christoph Langer wrote: >> Rajan Halade has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typos > > test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java > line 30:

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-21 Thread Rajan Halade
> Updated all the tests that depend on external infrastructure services as > manual. These tests may fail with external reasons, for instance - change in > CA test portal, certificate status updates, or network issues. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-21 Thread Sean Mullan
On Fri, 21 Jun 2024 16:11:34 GMT, Rajan Halade wrote: >> Updated all the tests that depend on external infrastructure services as >> manual. These tests may fail with external reasons, for instance - change in >> CA test portal, certificate status updates, or network issues. > > Rajan Halade ha

Integrated: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-21 Thread Rajan Halade
On Thu, 20 Jun 2024 18:35:00 GMT, Rajan Halade wrote: > Updated all the tests that depend on external infrastructure services as > manual. These tests may fail with external reasons, for instance - change in > CA test portal, certificate status updates, or network issues. This pull request has

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Sibabrata Sahoo
On Fri, 21 Jun 2024 16:09:49 GMT, Anthony Scarpino wrote: > > Just for knowledge: If the client has multiple PSK Identity previously > > shared by server and client initiate a PSK resumption of type(psk_dhe_ke) > > and it receive a HelloRetryRequest from Server, then should client send the >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 17:17:57 GMT, Sibabrata Sahoo wrote: > > > Just for knowledge: If the client has multiple PSK Identity previously > > > shared by server and client initiate a PSK resumption of type(psk_dhe_ke) > > > and it receive a HelloRetryRequest from Server, then should client send >

Re: RFR: 8324841: PKCS11 tests still skip execution

2024-06-21 Thread Valerie Peng
On Tue, 18 Jun 2024 12:13:13 GMT, Matthew Donovan wrote: > In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS > binaries are not found in a directory specified with the property > jdk.test.lib.artifacts.nsslib-. If the property is not specified, > the tests will throw a S

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread John Jiang
On Fri, 21 Jun 2024 15:35:46 GMT, Anthony Scarpino wrote: > Let me start from the beginning and hopefully it will clear things up. > > Today, each Finished connection gets one resumption ticket. That session's > SSLContext contains the cache. When someone wants to resume, they use the > same