On Mon, 15 Apr 2024 19:34:18 GMT, Anthony Scarpino
wrote:
>> Can you provide memory usage difference between the current and your
>> suggested change with `-prof gc`? With many of these situations, it's a
>> balance between memory usage and performance.
>
>> @ascarpino here's the `-prof gc` r
On Tue, 16 Apr 2024 00:15:34 GMT, Valerie Peng wrote:
> It is reported that some PKCS#11 library/vendor reports major version 3, but
> doesn't implement the C_GetInterface function and the resulting 'interface'
> variable value may be NULL and cause unexpected crash later.
>
> This PR would ch
On Tue, 9 Apr 2024 22:15:23 GMT, Valerie Peng wrote:
>> What about testing?
>
>> What about testing?
>
> I tested the change manually by changing some behavior to simulate the case.
> However, this cannot be done by regression test since NSS does not have
> legacy mechanisms.
> @valeriepeng c
On Tue, 16 Apr 2024 12:54:03 GMT, Weijun Wang wrote:
> Will something similar happen on Windows too?
The changes cover windows as well.
-
PR Comment: https://git.openjdk.org/jdk/pull/18789#issuecomment-2059540168
On Tue, 16 Apr 2024 05:59:55 GMT, Daniel Jeliński wrote:
>> It is reported that some PKCS#11 library/vendor reports major version 3, but
>> doesn't implement the C_GetInterface function and the resulting 'interface'
>> variable value may be NULL and cause unexpected crash later.
>>
>> This PR
> It is reported that some PKCS#11 library/vendor reports major version 3, but
> doesn't implement the C_GetInterface function and the resulting 'interface'
> variable value may be NULL and cause unexpected crash later.
>
> This PR would check the 'interface' variable value to be non-NULL.
> Rep
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote:
>> It is reported that some PKCS#11 library/vendor reports major version 3, but
>> doesn't implement the C_GetInterface function and the resulting 'interface'
>> variable value may be NULL and cause unexpected crash later.
>>
>> This PR wou
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote:
>> It is reported that some PKCS#11 library/vendor reports major version 3, but
>> doesn't implement the C_GetInterface function and the resulting 'interface'
>> variable value may be NULL and cause unexpected crash later.
>>
>> This PR wou
On Tue, 9 Apr 2024 18:37:44 GMT, Mark Powers wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to match CSR for disableLegacy -> allowLegacy name change
>
> What about testing?
@mcpowers I am about to leave f
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote:
>> It is reported that some PKCS#11 library/vendor reports major version 3, but
>> doesn't implement the C_GetInterface function and the resulting 'interface'
>> variable value may be NULL and cause unexpected crash later.
>>
>> This PR wou
On Tue, 16 Apr 2024 00:15:34 GMT, Valerie Peng wrote:
> It is reported that some PKCS#11 library/vendor reports major version 3, but
> doesn't implement the C_GetInterface function and the resulting 'interface'
> variable value may be NULL and cause unexpected crash later.
>
> This PR would ch
This brings in the CPU24_04 changes.
-
Commit messages:
- 8322122: Enhance generation of addresses
- 8319851: Improve exception logging
- 8318340: Improve RSA key implementations
- 8315708: Enhance HTTP/2 client usage
The merge commit only contains trivial merges, so no merge-spe
12 matches
Mail list logo