Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-16 Thread Oli Gillespie
On Mon, 15 Apr 2024 19:34:18 GMT, Anthony Scarpino wrote: >> Can you provide memory usage difference between the current and your >> suggested change with `-prof gc`? With many of these situations, it's a >> balance between memory usage and performance. > >> @ascarpino here's the `-prof gc` r

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries

2024-04-16 Thread Weijun Wang
On Tue, 16 Apr 2024 00:15:34 GMT, Valerie Peng wrote: > It is reported that some PKCS#11 library/vendor reports major version 3, but > doesn't implement the C_GetInterface function and the resulting 'interface' > variable value may be NULL and cause unexpected crash later. > > This PR would ch

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-16 Thread Valerie Peng
On Tue, 9 Apr 2024 22:15:23 GMT, Valerie Peng wrote: >> What about testing? > >> What about testing? > > I tested the change manually by changing some behavior to simulate the case. > However, this cannot be done by regression test since NSS does not have > legacy mechanisms. > @valeriepeng c

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries

2024-04-16 Thread Valerie Peng
On Tue, 16 Apr 2024 12:54:03 GMT, Weijun Wang wrote: > Will something similar happen on Windows too? The changes cover windows as well. - PR Comment: https://git.openjdk.org/jdk/pull/18789#issuecomment-2059540168

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries

2024-04-16 Thread Valerie Peng
On Tue, 16 Apr 2024 05:59:55 GMT, Daniel Jeliński wrote: >> It is reported that some PKCS#11 library/vendor reports major version 3, but >> doesn't implement the C_GetInterface function and the resulting 'interface' >> variable value may be NULL and cause unexpected crash later. >> >> This PR

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries [v2]

2024-04-16 Thread Valerie Peng
> It is reported that some PKCS#11 library/vendor reports major version 3, but > doesn't implement the C_GetInterface function and the resulting 'interface' > variable value may be NULL and cause unexpected crash later. > > This PR would check the 'interface' variable value to be non-NULL. > Rep

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries [v2]

2024-04-16 Thread Daniel Jeliński
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote: >> It is reported that some PKCS#11 library/vendor reports major version 3, but >> doesn't implement the C_GetInterface function and the resulting 'interface' >> variable value may be NULL and cause unexpected crash later. >> >> This PR wou

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries [v2]

2024-04-16 Thread Weijun Wang
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote: >> It is reported that some PKCS#11 library/vendor reports major version 3, but >> doesn't implement the C_GetInterface function and the resulting 'interface' >> variable value may be NULL and cause unexpected crash later. >> >> This PR wou

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-16 Thread Valerie Peng
On Tue, 9 Apr 2024 18:37:44 GMT, Mark Powers wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to match CSR for disableLegacy -> allowLegacy name change > > What about testing? @mcpowers I am about to leave f

Re: RFR: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries [v2]

2024-04-16 Thread Valerie Peng
On Tue, 16 Apr 2024 17:21:11 GMT, Valerie Peng wrote: >> It is reported that some PKCS#11 library/vendor reports major version 3, but >> doesn't implement the C_GetInterface function and the resulting 'interface' >> variable value may be NULL and cause unexpected crash later. >> >> This PR wou

Integrated: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries

2024-04-16 Thread Valerie Peng
On Tue, 16 Apr 2024 00:15:34 GMT, Valerie Peng wrote: > It is reported that some PKCS#11 library/vendor reports major version 3, but > doesn't implement the C_GetInterface function and the resulting 'interface' > variable value may be NULL and cause unexpected crash later. > > This PR would ch

RFR: Merge 33d7127

2024-04-16 Thread Jaikiran Pai
This brings in the CPU24_04 changes. - Commit messages: - 8322122: Enhance generation of addresses - 8319851: Improve exception logging - 8318340: Improve RSA key implementations - 8315708: Enhance HTTP/2 client usage The merge commit only contains trivial merges, so no merge-spe