Re: RFR: 8318756 Create better internal buffer for AEADs

2023-11-28 Thread Daniel Jeliński
On Tue, 28 Nov 2023 01:29:20 GMT, Anthony Scarpino wrote: >> test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java line 43: >> >>> 41: AlgorithmParameterSpec getNewSpec() { >>> 42: iv_index = (iv_index + 1) % IV_MODULO; >>> 43: return new GCMParameterSpec(96, iv, i

Re: RFR: 8318756 Create better internal buffer for AEADs

2023-11-28 Thread Daniel Jeliński
On Tue, 28 Nov 2023 00:49:58 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line >> 792: >> >>> 790: >>> 791: /* >>> 792: * Optimized version of bufferCrypt from CipherSpi.java. Direct >> >> Can you document the optimizations

Re: RFR: 8318756 Create better internal buffer for AEADs

2023-11-28 Thread Daniel Jeliński
On Fri, 3 Nov 2023 04:08:27 GMT, Anthony Scarpino wrote: > Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-11-28 Thread Sean Coffey
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote: > Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for bett

Re: RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v2]

2023-11-28 Thread Matthew Donovan
On Mon, 27 Nov 2023 14:47:29 GMT, Matthew Donovan wrote: >> In this PR, I included logic to skip tests on Oracle Linux prior to version >> 8. The NSS binaries we are using for testing use a newer version of GLIBC >> than is included with OL 7.9. > > Matthew Donovan has updated the pull request

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-11-28 Thread Sean Mullan
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote: > Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for bett

Re: JVM security properties warning

2023-11-28 Thread Sean Mullan
This should be discussed on the security-dev list, so let’s discuss and followup there. Bcc-ing idk-dev. —Sean On Nov 27, 2023, at 5:30 PM, Capasso, Autumn mailto:autum...@amazon.com>> wrote: Hi my name is Autumn Capasso, I am an Software engineer for the Amazon Corretto team. I am purposing

JVM security properties warning

2023-11-28 Thread Capasso, Autumn
Hi my name is Autumn Capasso, I am an Software engineer for the Amazon Corretto team. I am purposing to a mechanism to warn developers about misconfigure Security properties by mistaking them for system properties. We have found that customers are often confused by security properties they thin

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v2]

2023-11-28 Thread Ben Perez
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for better readability. Ben Perez has updated the pull reque

Re: RFR: 8318756 Create better internal buffer for AEADs

2023-11-28 Thread Anthony Scarpino
On Thu, 23 Nov 2023 12:13:45 GMT, Daniel Jeliński wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.

Re: RFR: 8320049: PKCS10 would not discard the cause when throw SignatureException on invalid key

2023-11-28 Thread Sean Mullan
On Tue, 14 Nov 2023 08:59:30 GMT, John Jiang wrote: > When throw SignatureException on invalid key, it may be better to contain the > cause exception. Looks fine to me, although I view this more as an Enhancement than a Bug. - Marked as reviewed by mullan (Reviewer). PR Review: h

Re: JVM security properties warning

2023-11-28 Thread Sean Mullan
Thanks for your post about this topic. A comment was added to the bug report and I also agree with the concerns raised there. I don’t think it can be implemented as expected for the reasons in that comment. Also, warnings emitted to stderr are not done lightly and are typically only done for ver

Re: RFR: 8315487: Security Providers Filter [v2]

2023-11-28 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Integrated: 8320049: PKCS10 would not discard the cause when throw SignatureException on invalid key

2023-11-28 Thread John Jiang
On Tue, 14 Nov 2023 08:59:30 GMT, John Jiang wrote: > When throw SignatureException on invalid key, it may be better to contain the > cause exception. This pull request has now been integrated. Changeset: 2c4c6c9b Author:John Jiang URL: https://git.openjdk.org/jdk/commit/2c4c6c9ba3

Re: RFR: 8320049: PKCS10 would not discard the cause when throw SignatureException on invalid key

2023-11-28 Thread John Jiang
On Tue, 28 Nov 2023 21:04:49 GMT, Sean Mullan wrote: >> When throw SignatureException on invalid key, it may be better to contain >> the cause exception. > > Looks fine to me, although I view this more as an Enhancement than a Bug. @seanjmullan Thanks for your review! I just switched the JBS