Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-10-25 Thread Stefan Karlsson
On Tue, 5 Sep 2023 18:05:34 GMT, Roger Riggs wrote: >> I have created an alternative that uses enums to force the user to make a >> decision: >> https://github.com/openjdk/jdk/compare/master...lkorinth:jdk:+process_tools >> . Another alternative is to do the same but instead using an enum (I t

Withdrawn: 8309330: Allow java.security to be extended via a properties directory

2023-10-25 Thread duke
On Fri, 2 Jun 2023 00:57:49 GMT, Andrew John Hughes wrote: > Currently, security properties are held within the `java.security` file in > the JDK tree for each installed JDK. The system property > `java.security.properties` can be used to point to a file containing > additional properties. The

Re: RFR: 8315097: Rename createJavaProcessBuilder [v7]

2023-10-25 Thread Leo Korinth
> This pull request renames `createJavaProcessBuilder` to > `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to > `createTestJavaProcessBuilder`. Both are implemented through a private > `createJavaProcessBuilder`. It also updates the java doc. > > This is so that it should be

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v3]

2023-10-25 Thread Weijun Wang
> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all > current and future public and private keys. > > No test. Might add one. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: AsymmetricKey - Change

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v6]

2023-10-25 Thread Xue-Lei Andrew Fan
On Fri, 20 Oct 2023 17:19:52 GMT, Xue-Lei Andrew Fan wrote: >> Hai-May Chao has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> co

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v6]

2023-10-25 Thread Hai-May Chao
On Wed, 18 Oct 2023 00:25:02 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v5]

2023-10-25 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional com

Re: RFR: 8315097: Rename createJavaProcessBuilder [v7]

2023-10-25 Thread Roger Riggs
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It al

Re: RFR: 8318096: Introduce AsymmetricKey interface with a getParams method [v4]

2023-10-25 Thread Weijun Wang
> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey` > and add a `getParams` method there. This makes it available to all current > and future public and private keys. > > No test. Might add one. Weijun Wang has updated the pull request incrementally with one additional

Re: RFR: 8318096: Introduce AsymmetricKey interface with a getParams method [v4]

2023-10-25 Thread Joe Darcy
On Thu, 26 Oct 2023 00:23:04 GMT, Weijun Wang wrote: >> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey` >> and add a `getParams` method there. This makes it available to all current >> and future public and private keys. >> >> No test. Might add one. > > Weijun Wang

Re: RFR: 8318096: Introduce AsymmetricKey interface with a getParams method [v5]

2023-10-25 Thread Weijun Wang
> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey` > and add a `getParams` method there. This makes it available to all current > and future public and private keys. > > No test. Might add one. Weijun Wang has updated the pull request incrementally with one additional

Re: [External] : Re: RFD: Services lockdown for security providers

2023-10-25 Thread Anthony Scarpino
Hi Martin, Thanks for the additional motivation. While thinking about this PR, I found that the filter can be inconsistently applied between JDK and 3rd party providers. The java providers use the JCA to build combined algorithms. For example, the ECDSAwithSHA1 that comes from SunEC uses get