Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12

2023-10-12 Thread Sean Mullan
On Wed, 11 Oct 2023 21:24:30 GMT, Kevin Driver wrote: > JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 The ones you changed to PKCS12 is fine, but you should also convert the binary keystores in the `test/jdk/javax/net/ssl/etc` directory. You can use the `keytool -impo

Re: RFR: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases [v3]

2023-10-12 Thread Sean Mullan
On Wed, 11 Oct 2023 21:23:01 GMT, Rajan Halade wrote: >> Template is updated to handle default cases and will also throw an Error on >> not supported test protocols. > > Rajan Halade has updated the pull request incrementally with one additional > commit since the last revision: > > No defau

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v2]

2023-10-12 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 - Changes: - all: https:

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12

2023-10-12 Thread Kevin Driver
On Thu, 12 Oct 2023 13:06:13 GMT, Sean Mullan wrote: > The ones you changed to PKCS12 is fine, but you should also convert the > binary keystores in the `test/jdk/javax/net/ssl/etc` directory. I have done so now. Please re-review. - PR Comment: https://git.openjdk.org/jdk/pull/16

Integrated: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases

2023-10-12 Thread Rajan Halade
On Wed, 11 Oct 2023 18:01:07 GMT, Rajan Halade wrote: > Template is updated to handle default cases and will also throw an Error on > not supported test protocols. This pull request has now been integrated. Changeset: 9728e21d Author:Rajan Halade URL: https://git.openjdk.org/jdk/co

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v3]

2023-10-12 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 - Changes: - all: https:

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v2]

2023-10-12 Thread Valerie Peng
On Wed, 11 Oct 2023 08:16:00 GMT, Andrey Turbanov wrote: >> A few classes in `com.sun.crypto.provider` package have non-final fields >> which could easily be marked `final`. > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Proposing the getParams method in PublicKey and PrivateKey

2023-10-12 Thread Wei-Jun Wang
Hi All, Currently, every algorithm-specific asymmetric key interface (Ex: ECKey) in JDK has a getParams() method. We are thinking about duplicating this method in PublicKey and PrivateKey (returning null by default) so the method is available for all asymmetric keys. Once we have this method, e

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v3]

2023-10-12 Thread Hai-May Chao
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank > you. Hai-May Chao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains thre