Re: RFR: 4964430: Missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal

2023-09-14 Thread Sean Mullan
On Wed, 13 Sep 2023 18:08:35 GMT, Ben Perez wrote: > Updated IllegalStateException exception requirements for `update`, `doFinal`, > `wrap`, and `unwrap` src/java.base/share/classes/javax/crypto/Cipher.java line 1855: > 1853: * @throws IllegalStateException if this {@code Cipher} object i

RFR: 8312126: NullPointerException in CertStore.getCRLs after 8297955

2023-09-14 Thread Sean Mullan
Please review this fix for a regression in the LDAP CertStore implementation where a null CRL issuerName in an X509CRLSelector should be treated as a CertStoreException instead of a NullPointerException. A new test has been added but requires internal infrastructure so will only be in the close

Re: RFR: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal [v2]

2023-09-14 Thread Ben Perez
> Updated IllegalStateException exception requirements for `update`, `doFinal`, > `wrap`, and `unwrap` Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Removed periods at end of IllegalStateException comment - Changes: -

Re: RFR: 8312126: NullPointerException in CertStore.getCRLs after 8297955

2023-09-14 Thread Weijun Wang
On Thu, 14 Sep 2023 14:59:07 GMT, Sean Mullan wrote: > Please review this fix for a regression in the LDAP CertStore implementation > where a null CRL issuerName in an X509CRLSelector should be treated as a > CertStoreException instead of a NullPointerException. > > A new test has been added b

Integrated: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-09-14 Thread Justin Lu
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote: > JDK .properties files still use ISO-8859-1 encoding with escape sequences. It > would improve readability to see the native characters instead of escape > sequences (especially for the L10n process). The majority of files changed > are local

Re: RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts

2023-09-14 Thread Valerie Peng
On Fri, 8 Sep 2023 19:41:47 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8296631 test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 74: > 72: if (version == 0.0 || version >= 3.55) { > 73: useSqlite(true); > 74: } Instead of updating variou