Re: RFR: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range. [v5]

2023-08-18 Thread Ben Perez
> Fixing the bug as stated would cause compatibility issues. E.g. the > `addProvider` function always adds new providers at position 0 and therefore > would always throw an error. Instead of changing how the function handles > indices, we instead have added this behavior to the function spec. B

Re: RFR: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range. [v4]

2023-08-18 Thread Valerie Peng
On Thu, 17 Aug 2023 21:30:17 GMT, Sean Mullan wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed function spec wording, updated test > > test/jdk/java/security/Provider/ChangeProviders.java line 1: > >> 1: /* >

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v4]

2023-08-18 Thread Julian Waters
On Thu, 17 Aug 2023 08:38:01 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin