Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v2]

2023-07-11 Thread Andrew John Hughes
On Fri, 2 Jun 2023 12:58:36 GMT, Andrew John Hughes wrote: >> Currently, security properties are held within the `java.security` file in >> the JDK tree for each installed JDK. The system property >> `java.security.properties` can be used to point to a file containing >> additional properties.

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v2]

2023-07-11 Thread Bernd
I don’t see the big advantage of changing the dir security property to avoid changing other  security property. It would be good if I don’t have to modify the system.properties file, for example by always adding a etc/security.custom.properties file if present, instead. Th

Re: RFR: 8311170: Simplify and modernize equals and hashCode in security area [v6]

2023-07-11 Thread Pavel Rappo
On Fri, 7 Jul 2023 19:21:29 GMT, Pavel Rappo wrote: > > Took another pass at this, looks good, but I would like to take another > > last look and make sure that changing the hash code for some of the classes > > like X509CRL is a benign change. > > Thanks, Sean. Take your time, you're an exper

RFR: JDK-8311892: TrustManagerFactory loading an invalid keystore yield vague exception

2023-07-11 Thread Craig Andrews
When loading the default JVM trust store, if the JVM trust store contains an invalid certificate, the exception contains insufficient information to determine which certificate is invalid, making it very difficult to fix the problem. To reproduce the issue: 1. Modify the default JVM trust store

RFR: 8295894: Remove SECOM certificate that is expiring in September 2023

2023-07-11 Thread Rajan Halade
The fix is to remove the expiring SECOM root certificate after approval from root CA to remove it. Release note is at - https://bugs.openjdk.org/browse/JDK-8311884 - Commit messages: - 8295894: Remove SECOM certificate that is expiring in September 2023 Changes: https://git.openjd

Re: RFR: 8295894: Remove SECOM certificate that is expiring in September 2023

2023-07-11 Thread Xue-Lei Andrew Fan
On Tue, 11 Jul 2023 20:42:14 GMT, Rajan Halade wrote: > The fix is to remove the expiring SECOM root certificate after approval from > root CA to remove it. > > Release note is at - https://bugs.openjdk.org/browse/JDK-8311884 Marked as reviewed by xuelei (Reviewer). - PR Review:

Re: RFR: 8311170: Simplify and modernize equals and hashCode in security area [v7]

2023-07-11 Thread Pavel Rappo
On Fri, 7 Jul 2023 23:19:27 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> `equals` and `hashCode` in security area. >> >> I understand that security area is sensitive and a non-expert, such as >> myself, should tread carefully; so belo

Re: RFR: 8295894: Remove SECOM certificate that is expiring in September 2023

2023-07-11 Thread Sean Mullan
On Tue, 11 Jul 2023 20:42:14 GMT, Rajan Halade wrote: > The fix is to remove the expiring SECOM root certificate after approval from > root CA to remove it. > > Release note is at - https://bugs.openjdk.org/browse/JDK-8311884 Marked as reviewed by mullan (Reviewer). - PR Review:

RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-07-11 Thread Valerie Peng
This change refactors the RSAPadding class to return an output record containing the status instead of relying on exception object to indicate a failure. Thanks in advance for review~ Valerie - Commit messages: - 8302017: Allocate BadPaddingException only if it will be thrown Cha

Integrated: 8295894: Remove SECOM certificate that is expiring in September 2023

2023-07-11 Thread Rajan Halade
On Tue, 11 Jul 2023 20:42:14 GMT, Rajan Halade wrote: > The fix is to remove the expiring SECOM root certificate after approval from > root CA to remove it. > > Release note is at - https://bugs.openjdk.org/browse/JDK-8311884 This pull request has now been integrated. Changeset: fd7fddb6 Auth