Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Serguei Spitsyn
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Incorporate review comments from Roger and tweak some code

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-14 Thread Sean Coffey
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev exclu

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-14 Thread Sean Coffey
On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits si

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated [v3]

2023-06-14 Thread Sean Mullan
On Tue, 13 Jun 2023 11:11:32 GMT, Matthew Donovan wrote: >> test/jdk/javax/net/ssl/TLS/TLSWontNegotiateDisabledCipherAlgos.java line 35: >> >>> 33: * @test id=Server >>> 34: * @bug 8301379 >>> 35: * @summary Verify that Java will not negotiate disabled cipher suites >>> when the >> >> This

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Sean Mullan
On Wed, 14 Jun 2023 11:52:35 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.base/share/classes/sun/launcher/LauncherHelper.ja

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-14 Thread Justin Lu
On Tue, 13 Jun 2023 18:50:42 GMT, Justin Lu wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties >> line 140: >> >>> 138: >>> 139: # 0: type, 1: name >>> 140: compiler.err.annotation.unrecognized.attribute.name=Annotation @{0} >>> weist das unbekannte

Re: RFD: Services lockdown for security providers

2023-06-14 Thread Sean Mullan
This proposal looks pretty good, although I think I would like to see more examples and a prototype if you have it. I think this would work well in conjunction with Sean Coffey's enhancement to add a security category to the java -XshowSettings option [1]. This would help debug issues with the

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Mandy Chung
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Lance Andersen
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Archie Cobbs
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > The following changes, to javac.1, were never applied to the closed sources > and are "lost" by this update. These changes will need to be re-applied > directly in JDK 21 and JDK 22 Just curious, since you have access to the secret closed

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v18]

2023-06-14 Thread Cesar Soares Lucas
> Can I please get reviews for this PR? > > The most common and frequent use of NonEscaping Phis merging object > allocations is for debugging information. The two graphs below show numbers > for Renaissance and DaCapo benchmarks - similar results are obtained for all > other applications that

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array

2023-06-14 Thread Sean Mullan
On Mon, 12 Jun 2023 18:49:59 GMT, Ben Perez wrote: > Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java line 99: > 97: byte[] safeEncoding = new

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v2]

2023-06-14 Thread Ben Perez
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Changed array copy to be more compact - Changes: - all:

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v2]

2023-06-14 Thread Ben Perez
On Wed, 14 Jun 2023 20:28:15 GMT, Sean Mullan wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed array copy to be more compact > > src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java > line

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v18]

2023-06-14 Thread Vladimir Ivanov
On Wed, 14 Jun 2023 19:29:45 GMT, Cesar Soares Lucas wrote: >> Can I please get reviews for this PR? >> >> The most common and frequent use of NonEscaping Phis merging object >> allocations is for debugging information. The two graphs below show numbers >> for Renaissance and DaCapo benchmar

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Anthony Scarpino
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread David Holmes
On Wed, 14 Jun 2023 19:21:01 GMT, Archie Cobbs wrote: > Just curious, since you have access to the secret closed sources, can you not > backport these changes yourself? Instead of just deleting them and expecting > someone else to rescue them from oblivion? @archiecobbs we (Oracle) will take

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread David Holmes
On Wed, 14 Jun 2023 09:25:14 GMT, Serguei Spitsyn wrote: >> Updated the version to 22-ea and year to 2024. >> >> The following unpublished changes will also be included in this update: >> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool >> manpage contains a special charact

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Archie Cobbs
On Wed, 14 Jun 2023 21:28:01 GMT, David Holmes wrote: > > Just curious, since you have access to the secret closed sources, can you > > not backport these changes yourself? Instead of just deleting them and > > expecting someone else to rescue them from oblivion? > > @archiecobbs we (Oracle) w

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Alan Bateman
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Alan Bateman
On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.base/share/classes/sun/launcher/LauncherHelper.j