Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-06 Thread Alan Bateman
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8182621: JSSE should reject empty TLS plaintexts

2023-04-06 Thread Rajan Halade
On Mon, 3 Apr 2023 18:13:19 GMT, Matthew Donovan wrote: > Added code similar to the suggested patches for empty Handshake messages. I > also implemented tests to verify empty Handshake, Alert, and ChangeCipherSpec > messages result in expected behavior: for SSLEngineImpl, exceptions are > thro

RFR: 8182621: JSSE should reject empty TLS plaintexts

2023-04-06 Thread Matthew Donovan
Added code similar to the suggested patches for empty Handshake messages. I also implemented tests to verify empty Handshake, Alert, and ChangeCipherSpec messages result in expected behavior: for SSLEngineImpl, exceptions are thrown, for SSLSockets the connection is closed. - Commi

Re: RFR: JDK-8305406: Add @spec tags in java.base/java.* (part 2) [v3]

2023-04-06 Thread Sean Mullan
On Wed, 5 Apr 2023 16:45:06 GMT, Jonathan Gibbons wrote: >> Please review a doc update to add `@spec` into the rest of the files in >> `java.base` (compared to those in >> [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248) > > Jonathan Gibbons has updated the pull request inc

Re: RFR: 8182621: JSSE should reject empty TLS plaintexts

2023-04-06 Thread Xue-Lei Andrew Fan
On Mon, 3 Apr 2023 18:13:19 GMT, Matthew Donovan wrote: > Added code similar to the suggested patches for empty Handshake messages. I > also implemented tests to verify empty Handshake, Alert, and ChangeCipherSpec > messages result in expected behavior: for SSLEngineImpl, exceptions are > thro

Re: RFR: 8304911: Use OperatingSystem enum in some modules [v3]

2023-04-06 Thread Jaikiran Pai
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs wrote: >> With the addition of `jdk.internal.util.OperatingSystem` references to the >> system property `os.name` can be replaced. >> This PR exports jdk.internal.util to: >> - java.prefs, >> - java.security.jgss, >> - java.smartcardio, >> - jdk.c