On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
>> line 188:
>>
>>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>>> 187:
>>> 188: main.plugin.category=\u7C7B\u522B
>>
>> As Naoto pointed out, it looks l
This patch modifies `CipherOutputStream` to avoid pointless memory allocations
when decrypting data using AEAD ciphers. This is related to #11597, which fixed
a similar issue in `CipherInputStream`.
`Cipher.update` does not output any data when doing AEAD decryption; all data
is buffered, and i
On Wed, 14 Dec 2022 18:41:35 GMT, Matthew Donovan wrote:
>> This fix is intended to address various time-out errors in tests that use
>> DTLSOverDatagram as a test template. Based on test output from those bugs
>> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
>> JDK-8268899
> This fix is intended to address various time-out errors in tests that use
> DTLSOverDatagram as a test template. Based on test output from those bugs
> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
> JDK-8268899), this fix:
>
> * refactors the class to only create one addi
On Thu, 15 Dec 2022 15:09:12 GMT, Jamil Nimeh wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> test/jdk/javax/net/ssl/DTLS/InvalidRecords.java line 42:
>
>> 40:
>> 41: /**
>> 42: * Test
- Reviewed the tests and created individual bugs for each.
- Updated @ignore tags with appropriate bug #.
- Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
expected result.
-
Commit messages:
- 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-i
On Wed, 14 Dec 2022 00:23:44 GMT, Valerie Peng wrote:
>> This RFE enhances existing PBE algorithms with the "SHA512/224" and
>> "SHA512/256" support.
>> Current transformation parsing in javax.crypto.Cipher class is re-written to
>> handle the additional "/" in the "SHA512/224" and "SHA512/256
On Thu, 15 Dec 2022 16:11:02 GMT, Matthew Donovan wrote:
> - Reviewed the tests and created individual bugs for each.
> - Updated @ignore tags with appropriate bug #.
> - Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
> expected result.
Looks good to me. Thanks!
--
> This patch modifies `CipherOutputStream` to avoid pointless memory
> allocations when decrypting data using AEAD ciphers. This is related to
> #11597, which fixed a similar issue in `CipherInputStream`.
>
> `Cipher.update` does not output any data when doing AEAD decryption; all data
> is buf
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line
>> 26:
>>
>>> 24: #
>>> 25:
>>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
>>> JMOD-Dateien auflisten
>>
>> `jlink.description` wa
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed trailing whitespace
Changes requested by naoto (Reviewer).
src/jdk.compil
On Thu, 15 Dec 2022 16:04:32 GMT, Matthew Donovan wrote:
>> This fix is intended to address various time-out errors in tests that use
>> DTLSOverDatagram as a test template. Based on test output from those bugs
>> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
>> JDK-8268899
On Thu, 15 Dec 2022 16:11:02 GMT, Matthew Donovan wrote:
> - Reviewed the tests and created individual bugs for each.
> - Updated @ignore tags with appropriate bug #.
> - Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
> expected result.
test/jdk/javax/net/ssl/SSLEngi
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote:
> This fix is intended to address various time-out errors in tests that use
> DTLSOverDatagram as a test template. Based on test output from those bugs
> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
> JDK-8268899), th
> - Reviewed the tests and created individual bugs for each.
> - Updated @ignore tags with appropriate bug #.
> - Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
> expected result.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a
On Thu, 15 Dec 2022 19:17:22 GMT, Rajan Halade wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> com
On Thu, 15 Dec 2022 18:06:38 GMT, Daniel Jeliński wrote:
>> This patch modifies `CipherOutputStream` to avoid pointless memory
>> allocations when decrypting data using AEAD ciphers. This is related to
>> #11597, which fixed a similar issue in `CipherInputStream`.
>>
>> `Cipher.update` does no
> Open l10n drop
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Fix https and changed URL back
-
Changes:
- all: https://git.openjdk.org/jdk20/pull/35/files
- new: https://git.openjdk.org/jdk20/pu
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed trailing whitespace
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties
> line 134
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
Thanks for the update, Damon. Looks good for this d
On Thu, 15 Dec 2022 20:07:34 GMT, Matthew Donovan wrote:
>> - Reviewed the tests and created individual bugs for each.
>> - Updated @ignore tags with appropriate bug #.
>> - Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
>> expected result.
>
> Matthew Donovan has upd
On Thu, 15 Dec 2022 18:06:38 GMT, Daniel Jeliński wrote:
>> This patch modifies `CipherOutputStream` to avoid pointless memory
>> allocations when decrypting data using AEAD ciphers. This is related to
>> #11597, which fixed a similar issue in `CipherInputStream`.
>>
>> `Cipher.update` does no
> Open l10n drop
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Revert double quote as well
-
Changes:
- all: https://git.openjdk.org/jdk20/pull/35/files
- new: https://git.openjdk.org/jdk20/pull/
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
Marked as reviewed by naoto (Reviewer).
src/jdk.jdeps
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
src/jdk.jpackage/share/classes/jdk/jpackage/interna
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/jdk.jpackage/windows/classes/jdk/jpackage/internal
On Thu, 15 Dec 2022 18:06:38 GMT, Daniel Jeliński wrote:
>> This patch modifies `CipherOutputStream` to avoid pointless memory
>> allocations when decrypting data using AEAD ciphers. This is related to
>> #11597, which fixed a similar issue in `CipherInputStream`.
>>
>> `Cipher.update` does no
On Thu, 15 Dec 2022 18:06:38 GMT, Daniel Jeliński wrote:
>> This patch modifies `CipherOutputStream` to avoid pointless memory
>> allocations when decrypting data using AEAD ciphers. This is related to
>> #11597, which fixed a similar issue in `CipherInputStream`.
>>
>> `Cipher.update` does no
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/java.base/share/classes/sun/security/tools/keytool
On Thu, 15 Dec 2022 22:46:47 GMT, Valerie Peng wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix test failure
>
> src/java.base/share/classes/javax/crypto/CipherOutputStream.java line 95:
>
>> 93: *
>> 9
On Thu, 15 Dec 2022 17:16:35 GMT, Bernd wrote:
> BTW while you touch the algorithm documentation, it Liste pkcs#5 which does
> work with octet strings, but the java api works with char passwords. It
> should describe that it uses the ucs2 char->bytes method not utf8 (pkcs8 vs
> pkcs12 if I rec
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix https and changed URL back
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_d
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix https and changed URL back
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
>> line 82:
>>
>>> 80:
>>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>>> app-image-Verzeichnis ({0})
>>> 82: error.invalid
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties
>> line 37:
>>
>>> 35:
>>> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u7
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev
wrote:
>> I'm not sure for the decisions of change in punctuation and for the missing
>> {1} as I didn't do the translation myself. Would this be better to be
>> reverted?
>
> Looks like translation is done on files before JDK-8293462 was int
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
The changes in the java.xml area look good to me.
---
> Open l10n drop
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Revert old translation. Fix lang codes
-
Changes:
- all: https://git.openjdk.org/jdk20/pull/35/files
- new: https://git.openjdk.org/
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed trailing whitespace
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote:
>> Looks like translation is done on files before JDK-8293462 was integrated
>> (before Sep 26). See
>> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f8
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl
>> line 2:
>>
>>> 1:
>>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="1252">
>>
>> Why "de-de" was changed to "de
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert double quote as well
>
> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
> line 75:
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
@dfuch Could I get a review from you as wel
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
`src/jdk.jdi/share/classes/com/sun/tools` c
On Thu, 15 Dec 2022 20:07:34 GMT, Matthew Donovan wrote:
>> - Reviewed the tests and created individual bugs for each.
>> - Updated @ignore tags with appropriate bug #.
>> - Removed @ignore for IllegalHandshakeMessage.java; the test passes with the
>> expected result.
>
> Matthew Donovan has upd
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
jpackage changes looks good.
-
On Wed, 14 Dec 2022 06:35:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes some typos in the files
>> under test/jdk/sun/security/tools/jarsigner/?
>
> Jaikiran Pai has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 14 Dec 2022 06:17:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the files
> under test/jdk/sun/security/tools/jarsigner/?
This pull request has now been integrated.
Changeset: e41686b4
Author:Jaikiran Pai
URL:
https://git.o
48 matches
Mail list logo
