Re: Disabled brainpool curves

2022-12-14 Thread benjamin.marwell
Yes, I know that. For the reasons I have given, I would like to request to remove brainpool 512 from that list for all users. There is no good reason to disable that cipher on JDK 8. It is not insecure, that has been debunked by the BSI. Any chance for this to happen? - Ben On 13.12.22, 18:5

Re: RFR: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/ [v2]

2022-12-14 Thread Lance Andersen
On Wed, 14 Dec 2022 06:35:11 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes some typos in the files >> under test/jdk/sun/security/tools/jarsigner/? > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider [v4]

2022-12-14 Thread Weijun Wang
On Wed, 14 Dec 2022 00:23:44 GMT, Valerie Peng wrote: >> This RFE enhances existing PBE algorithms with the "SHA512/224" and >> "SHA512/256" support. >> Current transformation parsing in javax.crypto.Cipher class is re-written to >> handle the additional "/" in the "SHA512/224" and "SHA512/256

Re: RFR: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-14 Thread Anthony Scarpino
On Thu, 8 Dec 2022 16:33:06 GMT, Daniel Jeliński wrote: > This patch modifies `CipherInputStream` to avoid pointless memory allocations > when decrypting data using AEAD ciphers. > > `Cipher.update` on AEAD decryption does not output any data; instead, all > data is buffered and returned in on

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-14 Thread Rajan Halade
On Tue, 13 Dec 2022 12:32:30 GMT, Matthew Donovan wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v3]

2022-12-14 Thread Matthew Donovan
> This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), this fix: > > * refactors the class to only create one addi

Re: RFR: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-14 Thread Valerie Peng
On Thu, 8 Dec 2022 16:33:06 GMT, Daniel Jeliński wrote: > This patch modifies `CipherInputStream` to avoid pointless memory allocations > when decrypting data using AEAD ciphers. > > `Cipher.update` on AEAD decryption does not output any data; instead, all > data is buffered and returned in on

[jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
Open l10n drop All tests passed - Commit messages: - open l10n drop Changes: https://git.openjdk.org/jdk20/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298133 Stats: 1177 lines in 110 files changed: 783

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Alisen Chung
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed looks good - Marked as reviewed by achung (Committer). PR: https://git.openjdk.org/jdk20/pull/35

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties line 188: > 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 > 187: > 188: main.plugin.category=\u7C7B\u522B As Naoto poin

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26: > 24: # > 25: > 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener > JMOD-Dateien auflisten `jlink.de

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties > line 188: > >> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >> 187: >> 188: main.plugin.category=\u7C7B\u522B > >

Re: RFR: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider [v4]

2022-12-14 Thread Valerie Peng
On Wed, 14 Dec 2022 14:25:22 GMT, Weijun Wang wrote: > I've added myself as a reviewer to the CSR. You might want to create a > release note and a subtask to update the provider doc. Thanks. Sure will, thanks for the reminder~ - PR: https://git.openjdk.org/jdk/pull/11339

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:04:12 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line > 26: > >> 24: # >> 25: >> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >> JMOD-Dateien auflisten

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-14 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Removed trailing whitespace - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/

Re: RFR: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-14 Thread Daniel Jeliński
On Thu, 8 Dec 2022 16:33:06 GMT, Daniel Jeliński wrote: > This patch modifies `CipherInputStream` to avoid pointless memory allocations > when decrypting data using AEAD ciphers. > > `Cipher.update` on AEAD decryption does not output any data; instead, all > data is buffered and returned in on

Integrated: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption

2022-12-14 Thread Daniel Jeliński
On Thu, 8 Dec 2022 16:33:06 GMT, Daniel Jeliński wrote: > This patch modifies `CipherInputStream` to avoid pointless memory allocations > when decrypting data using AEAD ciphers. > > `Cipher.update` on AEAD decryption does not output any data; instead, all > data is buffered and returned in on