Re: RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
On Fri, 9 Dec 2022 20:21:32 GMT, Sean Mullan wrote: > > > I tested the fix on all platforms and it passed. This is probably also > > > worth fixing in JDK 20 to get it off the ProblemList. > > > > > > Thanks for the review! What does fixing in `JDK 20` mean at this stage? > > File a PR agains

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-12 Thread Volker Simonis
On Sun, 11 Dec 2022 20:38:16 GMT, Xue-Lei Andrew Fan wrote: > > The same example with the 1000 connections being opened alternatively on > > two different contexts will instead create 1000 `StatelessKey` instances: > > That's obviously not the expected behaviors. It is a good catch for the > `

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-12 Thread Volker Simonis
On Sun, 11 Dec 2022 23:52:25 GMT, Sergey Bylokhov wrote: > > You're right, but that's actually an improvement compared to the initial > > implementation where cleanup/destroy wasn't synchronized at all :) > > With regards to the missing synchronization of key usage and key > > destruction, I th

Re: RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
On Fri, 9 Dec 2022 10:18:36 GMT, Severin Gehwolf wrote: > The test introduced with > [JDK-8298108](https://bugs.openjdk.org/browse/JDK-8298108) failed on Windows > apparently due to a non-portable use of `path.separator` in the test. > > @seanjmullan was kind enough to test this change, which

Withdrawn: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
On Fri, 9 Dec 2022 10:18:36 GMT, Severin Gehwolf wrote: > The test introduced with > [JDK-8298108](https://bugs.openjdk.org/browse/JDK-8298108) failed on Windows > apparently due to a non-portable use of `path.separator` in the test. > > @seanjmullan was kind enough to test this change, which

[jdk20] RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
Re-created the PR from https://git.openjdk.org/jdk/pull/11606 so as to get the test fixed in JDK 20. According to https://openjdk.org/jeps/3 test and documentation bugs are eligible during RDP 1 and RDP 2 provided they have a `noreg-self` label, which this bug has. - Commit message

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts

2022-12-12 Thread Sergey Bylokhov
On Mon, 12 Dec 2022 10:06:19 GMT, Volker Simonis wrote: > `encrypt()` will call `getCurrentKey()` which isn't synchronized. If we think that all that try/catch blocks in the encode/cleanup will save us, then why we added the sync block around cleanup. But If we try synchronize work with keys,

Re: [jdk20] RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Sean Mullan
On Mon, 12 Dec 2022 10:37:18 GMT, Severin Gehwolf wrote: > Re-created the PR from https://git.openjdk.org/jdk/pull/11606 so as to get > the test fixed in JDK 20. According to https://openjdk.org/jeps/3 test and > documentation bugs are eligible during RDP 1 and RDP 2 provided they have a > `no

Re: [jdk20] RFR: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
On Mon, 12 Dec 2022 10:37:18 GMT, Severin Gehwolf wrote: > Re-created the PR from https://git.openjdk.org/jdk/pull/11606 so as to get > the test fixed in JDK 20. According to https://openjdk.org/jeps/3 test and > documentation bugs are eligible during RDP 1 and RDP 2 provided they have a > `no

[jdk20] Integrated: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

2022-12-12 Thread Severin Gehwolf
On Mon, 12 Dec 2022 10:37:18 GMT, Severin Gehwolf wrote: > Re-created the PR from https://git.openjdk.org/jdk/pull/11606 so as to get > the test fixed in JDK 20. According to https://openjdk.org/jeps/3 test and > documentation bugs are eligible during RDP 1 and RDP 2 provided they have a > `no

RFR: Merge jdk20

2022-12-12 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8297288: Example code in Scanner class - 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows - 8298459: Fix msys2 linking and

Integrated: 8297505: Declare fields in some sun.security.pkcs11 classes as final

2022-12-12 Thread Per Minborg
On Thu, 24 Nov 2022 08:13:58 GMT, Per Minborg wrote: > This PR proposes declaring some fields as `final` to potentially unlock > performance optimisations and improve thread visibility (e.g. for GC > threads). The PR also fixes a "synchronising on a non-final field" > anti-pattern. This pull

Disabled brainpool curves

2022-12-12 Thread benjamin.marwell
Hi everyone! I just stumbled over “Disable weak named curves”, e.g. • https://bugs.openjdk.org/browse/JDK-8235540 • http://cr.openjdk.java.net/~alexsch/sercher/8233228/webrev.00/src/share/lib/security/java.security-aix.udiff.html Interestingly, brainpoolP512r1 is on that list. Just a few weeks