On Tue, 6 Dec 2022 20:40:34 GMT, Roger Riggs wrote:
> The existing code more obviously handles memory deallocation.
Thomas Stuefe suggested something like this
JNU_CHECK_EXCEPTION_DO(env, action)
JNU_CHECK_EXCEPTION_DO_AND_RETURN(env, action, retval)
usage example:
`JNU_CHECK_EXCEPTION_DO(e
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote:
>> Please review this test addition as it would have helped discover a
>> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
>> and subsequently backported. What's more, it might help discover similar
>> issues goi
On Mon, 5 Dec 2022 15:21:51 GMT, Severin Gehwolf wrote:
> Please review this test addition as it would have helped discover a
> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
> and subsequently backported. What's more, it might help discover similar
> issues going f
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
This fix is intended to address various time-out errors in tests that use
DTLSOverDatagram as a test template. Based on test output from those bugs
(JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, JDK-8268899),
this fix:
* refactors the class to only create one additional threa
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote:
>> Please review this test addition as it would have helped discover a
>> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
>> and subsequently backported. What's more, it might help discover similar
>> issues goi
The test is failing on Windows. Problem list it until it can get properly
analyzed and fixed.
-
Commit messages:
- 8298274: Problem list TestSPISigned on Windows
Changes: https://git.openjdk.org/jdk/pull/11560/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11560&range=00
On Wed, 7 Dec 2022 14:41:03 GMT, Severin Gehwolf wrote:
> The test is failing on Windows. Problem list it until it can get properly
> analyzed and fixed.
Marked as reviewed by mullan (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11560
On Wed, 7 Dec 2022 06:56:28 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
On Wed, 7 Dec 2022 14:41:03 GMT, Severin Gehwolf wrote:
> The test is failing on Windows. Problem list it until it can get properly
> analyzed and fixed.
Thumbs up. This is a trivial fix.
Your ProblemList entry is properly formed. Please go ahead and integrate.
-
Marked as review
On Wed, 7 Dec 2022 14:41:03 GMT, Severin Gehwolf wrote:
> The test is failing on Windows. Problem list it until it can get properly
> analyzed and fixed.
If somebody could test that the problem list entry works as expected on
Windows, I'd appreciate it (I'm not touching those files much). Happ
On Wed, 7 Dec 2022 14:41:03 GMT, Severin Gehwolf wrote:
> The test is failing on Windows. Problem list it until it can get properly
> analyzed and fixed.
This pull request has now been integrated.
Changeset: 29f1c3c6
Author:Severin Gehwolf
URL:
https://git.openjdk.org/jdk/commit/29
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
Good idea, though perhaps the return (and value if any) could be explicit in
the macro invocati
On Wed, 7 Dec 2022 16:27:43 GMT, Roger Riggs wrote:
>
> Good idea, though perhaps the return (and value if any) could be explicit in
> the macro invocation, instead of implicit (plus arg). A single macro would
> suffice, instead of multiples.
>
> Usage Example:
>
> ```
> JNU_CHECK_EXCEPT
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Wed, 7 Dec 2022 11:54:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Making the wrapper classes static
>
> src/java.base/share/classes/java/io/Console.java line 625:
>
>> 623: };
On Wed, 7 Dec 2022 17:09:53 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Wed, 7 Dec 2022 06:56:28 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Wed, 7 Dec 2022 18:57:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java line 167:
>
>> 165: @Over
On Fri, 5 Aug 2022 14:57:45 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support key exchange named groups customization for
> individual (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.org/browse/JDK-8291950
> RFE: https://bugs.openjdk.org/browse/JDK-8281236
On Wed, 7 Dec 2022 19:19:25 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote:
> This fix is intended to address various time-out errors in tests that use
> DTLSOverDatagram as a test template. Based on test output from those bugs
> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
> JDK-8268899), th
On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato wrote:
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal
Hello, Security team.
Right now I am working on some issues related to the sslContext and would like to clarify a few
questions about how the feature implemented by the JDK-8211018 is intended to work.
That feature is mostly implemented by this class:
https://github.com/openjdk/jdk/blob/4cec141
This PR suggests renaming various names from "session" to "scope" in accordance
with https://openjdk.org/jeps/434
The PRs contains changes for several sub-components.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11573/files
Webrev: https:
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
src/java.base/share/classes/jdk/internal/foreign/MemoryScopeImpl.ja
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
I think we should split this PR into multiple parts:
* there are so
28 matches
Mail list logo
