Integrated: 8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException

2022-12-06 Thread Daniel Jeliński
On Thu, 1 Dec 2022 16:37:48 GMT, Daniel Jeliński wrote: > This patch fixes the exceptions that may occur when merging IP address > NameConstraints from different certificates in a chain. > > The included test reports 3 exceptions without the fix, passes with the fix > applied. > > Tiers 1-3 c

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-06 Thread Severin Gehwolf
On Mon, 5 Dec 2022 21:07:20 GMT, Sean Mullan wrote: > Since this is a different way of testing the same underlying issue and the > problem shows up in more than one way, I agree it is a good idea to add > another regression test. However, I would put in the same test directory as > 8280890: te

Re: RFR: 8296024: Usage of DirectBuffer::address should be guarded [v18]

2022-12-06 Thread Per Minborg
> This PR proposes the introduction of **guarding** of the use of > `DirectBuffer::address` within the JDK. With the introduction of the Foreign > Function and Memory access, it is possible to derive Buffer instances that > are backed by native memory that, in turn, can be closed asynchronously

Integrated: 8296024: Usage of DirectBuffer::address should be guarded

2022-12-06 Thread Per Minborg
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote: > This PR proposes the introduction of **guarding** of the use of > `DirectBuffer::address` within the JDK. With the introduction of the Foreign > Function and Memory access, it is possible to derive Buffer instances that > are backed by nat

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v4]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v4]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 10:50:30 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-06 Thread Alan Bateman
On Tue, 6 Dec 2022 07:35:44 GMT, Jaikiran Pai wrote: > So the `Console` instance returned from `System.console()`, thus far, follows > these semantics. However, with the change proposed in this PR, the default > implementation will now be the jline backed `JdkConsoleImpl` implementation. > Fro

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 11:13:29 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

RFR: JDK-8298170 : Introduce a macro for exception check, free and return

2022-12-06 Thread Matthias Baesken
We have a number of places in the codebase where a macro could help when we check an exception and afterwrads free something and return. - Commit messages: - JDK-8298170 Changes: https://git.openjdk.org/jdk/pull/11539/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11539&r

Integrated: 8297379: Enable the ByteBuffer path of Poly1305 optimizations

2022-12-06 Thread Volodymyr Paprotski
On Wed, 23 Nov 2022 23:33:32 GMT, Volodymyr Paprotski wrote: > There is now an intrinsic for Poly1305, which is only enabled on the > `engineUpdate([]byte)` path. This PR adds intrinsic support > `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). > > Fuzzing test expanded to also inc

Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 15:09:25 GMT, Sean Mullan wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust test setup > > test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.jav

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 17:29:40 GMT, Severin Gehwolf wrote: >> test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights >>> reserved. >> >> Did you copy th

Re: RFR: 8295803: Console should be usable in jshell and other environments [v8]

2022-12-06 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-06 Thread Naoto Sato
On Tue, 6 Dec 2022 06:19:37 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed the copyright year > > src/java.base/share/classes/java/io/Console.java line 99: > >> 97: */ >> 98: >> 99: public

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-06 Thread Naoto Sato
On Tue, 6 Dec 2022 07:34:45 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/Console.java line 616: >> >>> 614: >>> JdkConsoleProvider.DEFAULT_PROVIDER_MODULE_NAME); >>> 615: return >>> ServiceLoader.load(JdkConsoleProvider.class).stream()

Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: JDK-8298170 : Introduce a macro for exception check, free and return

2022-12-06 Thread Phil Race
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote: > We have a number of places in the codebase where a macro could help when we > check an exception and afterwrads free something and return. I'm OK with the idea and the specific desktop change. I'll leave the rest to the appropriate com

Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8295803: Console should be usable in jshell and other environments [v9]

2022-12-06 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8295803: Console should be usable in jshell and other environments [v9]

2022-12-06 Thread Naoto Sato
On Tue, 6 Dec 2022 19:17:44 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >> `jdk.inter

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v5]

2022-12-06 Thread Anthony Scarpino
> I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > method during decryption. A temporary buffer was used because

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v6]

2022-12-06 Thread Anthony Scarpino
> I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > method during decryption. A temporary buffer was used because

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v7]

2022-12-06 Thread Anthony Scarpino
> I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > method during decryption. A temporary buffer was used because

Re: RFR: JDK-8298170 : Introduce a macro for exception check, free and return

2022-12-06 Thread Roger Riggs
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote: > We have a number of places in the codebase where a macro could help when we > check an exception and afterwrads free something and return. The existing (and new) macro naming doesn't make clear that it always returns from the function

Integrated: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-12-06 Thread Mark Powers
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 This pull request has now been integrated. Changeset: 79d163d4 Author:Mark Powers Committer: Weijun Wang URL: https://git.openjdk.org/jdk/commit/79d163d4994d235266117b425498b0df3d16c3

Integrated: 8296507: GCM using more memory than necessary with in-place operations

2022-12-06 Thread Anthony Scarpino
On Sun, 13 Nov 2022 02:54:10 GMT, Anthony Scarpino wrote: > I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > m

Re: RFR: 8295803: Console should be usable in jshell and other environments [v10]

2022-12-06 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8295803: Console should be usable in jshell and other environments [v11]

2022-12-06 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-06 Thread Xue-Lei Andrew Fan
On Tue, 6 Dec 2022 18:45:57 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains six commits: >> >> - check duplicate >> - Merge >> - Merge >> - Merge >> - add test cases >> - 8281236

Re: RFR: 8281236: (D)TLS key exchange named groups [v5]

2022-12-06 Thread Xue-Lei Andrew Fan
> This update is to support key exchange named groups customization for > individual (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.org/browse/JDK-8291950 > RFE: https://bugs.openjdk.org/browse/JDK-8281236 > Release-note: https://bugs.openjdk.org/browse/JDK-8291975 >

Re: RFR: 8295803: Console should be usable in jshell and other environments [v11]

2022-12-06 Thread Alan Bateman
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >> `jdk.inter

Re: RFR: 8295803: Console should be usable in jshell and other environments [v11]

2022-12-06 Thread Alan Bateman
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >> `jdk.inter