On Thu, 1 Dec 2022 16:37:48 GMT, Daniel Jeliński wrote:
> This patch fixes the exceptions that may occur when merging IP address
> NameConstraints from different certificates in a chain.
>
> The included test reports 3 exceptions without the fix, passes with the fix
> applied.
>
> Tiers 1-3 c
On Mon, 5 Dec 2022 21:07:20 GMT, Sean Mullan wrote:
> Since this is a different way of testing the same underlying issue and the
> problem shows up in more than one way, I agree it is a good idea to add
> another regression test. However, I would put in the same test directory as
> 8280890: te
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by nat
> Please review this test addition as it would have helped discover a
> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
> and subsequently backported. What's more, it might help discover similar
> issues going forward. Thoughts?
>
> Testing: Manually produced a build
> Please review this test addition as it would have helped discover a
> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
> and subsequently backported. What's more, it might help discover similar
> issues going forward. Thoughts?
>
> Testing: Manually produced a build
On Tue, 6 Dec 2022 10:50:30 GMT, Severin Gehwolf wrote:
>> Please review this test addition as it would have helped discover a
>> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
>> and subsequently backported. What's more, it might help discover similar
>> issues goi
On Tue, 6 Dec 2022 07:35:44 GMT, Jaikiran Pai wrote:
> So the `Console` instance returned from `System.console()`, thus far, follows
> these semantics. However, with the change proposed in this PR, the default
> implementation will now be the jline backed `JdkConsoleImpl` implementation.
> Fro
On Tue, 6 Dec 2022 11:13:29 GMT, Severin Gehwolf wrote:
>> Please review this test addition as it would have helped discover a
>> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
>> and subsequently backported. What's more, it might help discover similar
>> issues goi
We have a number of places in the codebase where a macro could help when we
check an exception and afterwrads free something and return.
-
Commit messages:
- JDK-8298170
Changes: https://git.openjdk.org/jdk/pull/11539/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11539&r
On Wed, 23 Nov 2022 23:33:32 GMT, Volodymyr Paprotski wrote:
> There is now an intrinsic for Poly1305, which is only enabled on the
> `engineUpdate([]byte)` path. This PR adds intrinsic support
> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`).
>
> Fuzzing test expanded to also inc
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
On Tue, 6 Dec 2022 15:09:25 GMT, Sean Mullan wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adjust test setup
>
> test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.jav
> Please review this test addition as it would have helped discover a
> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
> and subsequently backported. What's more, it might help discover similar
> issues going forward. Thoughts?
>
> Testing: Manually produced a build
On Tue, 6 Dec 2022 17:29:40 GMT, Severin Gehwolf wrote:
>> test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Did you copy th
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 06:19:37 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed the copyright year
>
> src/java.base/share/classes/java/io/Console.java line 99:
>
>> 97: */
>> 98:
>> 99: public
On Tue, 6 Dec 2022 07:34:45 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/Console.java line 616:
>>
>>> 614:
>>> JdkConsoleProvider.DEFAULT_PROVIDER_MODULE_NAME);
>>> 615: return
>>> ServiceLoader.load(JdkConsoleProvider.class).stream()
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
I'm OK with the idea and the specific desktop change.
I'll leave the rest to the appropriate com
On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support key exchange named groups customization for
>> individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 19:17:44 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
> I would like a review of an update to the GCM code. A recent report showed
> that GCM memory usage for TLS was very large. This was a result of in-place
> buffers, which TLS uses, and how the code handled the combined intrinsic
> method during decryption. A temporary buffer was used because
> I would like a review of an update to the GCM code. A recent report showed
> that GCM memory usage for TLS was very large. This was a result of in-place
> buffers, which TLS uses, and how the code handled the combined intrinsic
> method during decryption. A temporary buffer was used because
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote:
>> Please review this test addition as it would have helped discover a
>> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced
>> and subsequently backported. What's more, it might help discover similar
>> issues goi
> I would like a review of an update to the GCM code. A recent report showed
> that GCM memory usage for TLS was very large. This was a result of in-place
> buffers, which TLS uses, and how the code handled the combined intrinsic
> method during decryption. A temporary buffer was used because
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
The existing (and new) macro naming doesn't make clear that it always returns
from the function
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8293412
This pull request has now been integrated.
Changeset: 79d163d4
Author:Mark Powers
Committer: Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/79d163d4994d235266117b425498b0df3d16c3
On Sun, 13 Nov 2022 02:54:10 GMT, Anthony Scarpino
wrote:
> I would like a review of an update to the GCM code. A recent report showed
> that GCM memory usage for TLS was very large. This was a result of in-place
> buffers, which TLS uses, and how the code handled the combined intrinsic
> m
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Tue, 6 Dec 2022 18:45:57 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains six commits:
>>
>> - check duplicate
>> - Merge
>> - Merge
>> - Merge
>> - add test cases
>> - 8281236
> This update is to support key exchange named groups customization for
> individual (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.org/browse/JDK-8291950
> RFE: https://bugs.openjdk.org/browse/JDK-8281236
> Release-note: https://bugs.openjdk.org/browse/JDK-8291975
>
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
On Tue, 6 Dec 2022 22:45:52 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>> `jdk.inter
37 matches
Mail list logo