On Thu, 1 Dec 2022 23:38:40 GMT, Weijun Wang wrote:
>> I confirmed that the standalone `keytool` did not echo the input, which
>> should be OK for this IMO.
>
> If the console cannot be used anyway inside jshell, then this is good enough.
Naoto has confirmed that the password prompt from keytoo
On Thu, 1 Dec 2022 19:36:16 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> lis
On Thu, 1 Sep 2022 23:25:16 GMT, Weijun Wang wrote:
> Since the algorithm is already encoded inside a PKCS #8 data block, it is not
> necessary to provide an algorithm when a `PKCS8EncodedKeySpec` object is
> created. The same for `X509EncodedKeySpec`.
This pull request has been closed without
On Fri, 2 Dec 2022 08:18:35 GMT, Alan Bateman wrote:
>> If the console cannot be used anyway inside jshell, then this is good enough.
>
> Naoto has confirmed that the password prompt from keytool does not echo, good!
>
> The intention is that Console be usable in jshell so I think the issue is
According to [the
specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
trailing whitespaces in the values of properties files are (somewhat
surprisingly) actually significant.
We have multiple files in the JDK with trailing
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote:
> and instead I have split up this work in five different bugs
would you consider also adding a unit test to check whether the localized
resources also contain leading/trailing whitespace, and possibly special
characters (like {, }, ,
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Fri, 2 Dec 2022 15:21:40 GMT, Weijun Wang wrote:
>> Naoto has confirmed that the password prompt from keytool does not echo,
>> good!
>>
>> The intention is that Console be usable in jshell so I think the issue is
>> that readPassword is echo'ing when used in jshell. Maybe someone
>> exper
On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote:
>> This turned out to be much more complicated than anticipated. I am going to
>> close this PR (and bug), and instead I have split up this work in five
>> different bugs:
>>
>> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047) is
On Mon, 28 Nov 2022 20:09:34 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove extra whitespace
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 325:
>
>> 323: * index 2
> This RFE enhances existing PBE algorithms with the "SHA512/224" and
> "SHA512/256" support.
> Current transformation parsing in javax.crypto.Cipher class is re-written to
> handle the additional "/" in the "SHA512/224" and "SHA512/256" algorithm
> names. Existing tests are updated with the ad
On Wed, 30 Nov 2022 19:44:00 GMT, Xue-Lei Andrew Fan wrote:
> > Please add a test that verifies that the worst case calculation still
> > produces correct results. That is:
> >
> > * build a number where the limb values are as high as possible
> > (2^(numLimbs*bitsPerLimb)-1, or something clos
16 matches
Mail list logo
