Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-22 Thread Florent Guillaume
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 Given the repeated code wouldn't you want to create a small helper method like `getIDNullSafe`? - PR: https://git.openjdk.org/jdk/pull/10823

Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-22 Thread Xue-Lei Andrew Fan
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 There are some other places, for example in updatePkey(), that use cka_id. Did you have a chance to check if NPE is possible there as well? - PR: https://git.openjdk.org/jdk/pull/10