RFR: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Magnus Ihse Bursie
Markdown files are basically source code for documentation. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes. - Commit messages: - 8295205: Add jcheck whitespace checking for markdown files Changes: https://gi

Re: RFR: 8294906: Memory leak in PKCS11 NSS TLS server [v3]

2022-10-12 Thread Daniel Jeliński
> C_DeriveKey with mechanisms `CKM_*_KEY_AND_MAC_DERIVE` always returns mac > keys, even if macBits is zero. These keys must be free'd when no longer > needed. > > Verified that: > - SSL server configured with PKCS11-NSS provider leaks memory without this > patch, does not leak memory with this

Re: RFR: 8294906: Memory leak in PKCS11 NSS TLS server [v2]

2022-10-12 Thread Daniel Jeliński
On Fri, 7 Oct 2022 07:42:25 GMT, Daniel Jeliński wrote: >> C_DeriveKey with mechanisms `CKM_*_KEY_AND_MAC_DERIVE` always returns mac >> keys, even if macBits is zero. These keys must be free'd when no longer >> needed. >> >> Verified that: >> - SSL server configured with PKCS11-NSS provider le

Re: RFR: 8294997: Improve ECC math operations

2022-10-12 Thread Daniel Jeliński
On Tue, 11 Oct 2022 17:30:02 GMT, Xue-Lei Andrew Fan wrote: >> This patch rewrites some BigInteger and curve point operations used in EC >> calculations: >> - coefficient * 2^power is equivalent to coefficient << power >> - number mod 2^n is equivalent to number & (2^n-1) >> - pair of IntegerMod

Re: RFR: 8294997: Improve ECC math operations [v2]

2022-10-12 Thread Daniel Jeliński
> This patch rewrites some BigInteger and curve point operations used in EC > calculations: > - coefficient * 2^power is equivalent to coefficient << power > - number mod 2^n is equivalent to number & (2^n-1) > - pair of IntegerModuloP operations: > t2 = t1+t1 > t1 = t1+t2 > is equivalent to t1=t1

Re: RFR: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Erik Joelsson
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote: > Markdown files are basically source code for documentation. It should have > the same whitespace checks as all other source code, so we don't get spurious > trailing whitespace changes. Thank you! Since I enabled visible whitespace

Integrated: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Magnus Ihse Bursie
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote: > Markdown files are basically source code for documentation. It should have > the same whitespace checks as all other source code, so we don't get spurious > trailing whitespace changes. This pull request has now been integrated. Ch

Re: RFR: 8294906: Memory leak in PKCS11 NSS TLS server [v3]

2022-10-12 Thread Mark Powers
On Wed, 12 Oct 2022 12:13:20 GMT, Daniel Jeliński wrote: >> C_DeriveKey with mechanisms `CKM_*_KEY_AND_MAC_DERIVE` always returns mac >> keys, even if macBits is zero. These keys must be free'd when no longer >> needed. >> >> Verified that: >> - SSL server configured with PKCS11-NSS provider l

Re: RFR: 8294997: Improve ECC math operations [v2]

2022-10-12 Thread Xue-Lei Andrew Fan
On Wed, 12 Oct 2022 12:31:20 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial.java >> line 332: >> >>> 330: >>> 331: protected void setLimbsValuePositive(BigInteger v, long[] limbs) { >>> 332: assert bitsPerLimb < 32; >> >

Re: RFR: 8294997: Improve ECC math operations [v2]

2022-10-12 Thread Xue-Lei Andrew Fan
On Wed, 12 Oct 2022 12:43:09 GMT, Daniel Jeliński wrote: >> This patch rewrites some BigInteger and curve point operations used in EC >> calculations: >> - coefficient * 2^power is equivalent to coefficient << power >> - number mod 2^n is equivalent to number & (2^n-1) >> - pair of IntegerModulo

Integrated: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

2022-10-12 Thread Daniel Jeliński
On Tue, 11 Oct 2022 14:38:35 GMT, Daniel Jeliński wrote: > This patch fixes the issue where a thread doing SSLSocket.close() could > destroy the read cipher while it was used by another thread doing > SSLSocket.read(). > > The reported issue was triggered by SSLSocket.close() calling > inputR

Re: RFR: 8295010: EC limbs addition and subtraction limit [v2]

2022-10-12 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? With this update, the result will be always > reduced in EC limbs addition and subtraction operations in the JDK > implementation. > > In the current implementation, the EC limbs addition and subtraction result > is not reduced before the value is re

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-12 Thread Naoto Sato
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains cha

Re: RFR: 8295010: EC limbs addition and subtraction limit [v3]

2022-10-12 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? With this update, the result will be always > reduced in EC limbs addition and subtraction operations in the JDK > implementation. > > In the current implementation, the EC limbs addition and subtraction result > is not reduced before the value is re

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v3]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification whic

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification whic

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Naoto Sato
On Wed, 12 Oct 2022 18:31:16 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains cha

Integrated: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-12 Thread Bill Huang
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote: > The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes