Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-03 Thread Sean Coffey
> New JFR event to record state of initial security properties. > > Debug output is also now added for these properties via > -Djava.security.debug=properties Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Check for 0 security even

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-03 Thread Sean Coffey
On Fri, 30 Sep 2022 19:32:29 GMT, Sean Mullan wrote: >> Thanks @egahlin - maybe we can leave it at beginChunk setting then. >> >> I've been doing some testing to satisfy myself that the impact of this event >> on performance is minimal, Running the new `emitInitialSecurityProperties()` >> is

RFR: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

2022-10-03 Thread Daniel Jeliński
This PR reduces the execution time of ProxyAuthTest. Before this change the test always required at least 3 minutes to complete (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`). After this change the test does not open a server socket when it is not necessary. The tes

Re: RFR: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

2022-10-03 Thread Daniel Fuchs
On Mon, 3 Oct 2022 14:35:46 GMT, Daniel Jeliński wrote: > This PR reduces the execution time of ProxyAuthTest. > > Before this change the test always required at least 3 minutes to complete > (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`). > After this change the te

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-10-03 Thread Joe Darcy
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote: > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > might warrant a separate PR..? Filed a few follow-up bugs: JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella) JDK-8294725: Update openjdk.java.n

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v6]

2022-10-03 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v7]

2022-10-03 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-10-03 Thread Joe Darcy
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote: > > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > > might warrant a separate PR..? > > Filed a few follow-up bugs: > > JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella) > JDK-8294725: Update

RFR: 8294734: Redundant override in AES implementation

2022-10-03 Thread Xue-Lei Andrew Fan
Hi, May I have this simple code clean-up patch reviewed? In the AES cipher implementation, the override of engineDoFinal() method in the following code is not necessary as it only calls super. The throws descriptions are missed in the method description. I may be better to remove this overri

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v7]

2022-10-03 Thread Phil Race
On Mon, 3 Oct 2022 17:29:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated the

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v8]

2022-10-03 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a re

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v7]

2022-10-03 Thread Joe Darcy
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update make directory. > > src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line > 36: > >> 34: * >

Re: RFR: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

2022-10-03 Thread Jaikiran Pai
On Mon, 3 Oct 2022 14:35:46 GMT, Daniel Jeliński wrote: > This PR reduces the execution time of ProxyAuthTest. > > Before this change the test always required at least 3 minutes to complete > (6x 30 seconds timeout in `SSLSocketTemplate`'s `sslServerSocket.accept()`). > After this change the te