8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
-
Commit messages:
- Remove file that was removed upstream
- Fix inconsistency in capitalization
- Undo change in zlip
- Fix typos
Changes: https://git.openjdk.org/jdk/pull/10029/files
Webrev: https://we
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
> If you already are an OpenJDK
> [Author](https://openjdk.java.net/bylaws#author),
> [Committer](https://openjdk.java.net/bylaws#committer) or
> [Reviewer](htt
On Thu, 25 Aug 2022 19:55:47 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
>> If you already are an OpenJDK
>> [Author](https://openjdk.java.net/bylaws#author),
>> [Committer](https://openjdk.java.net/bylaws#committer) or
>> [Reviewe
On Mon, 5 Sep 2022 06:32:44 GMT, Jaikiran Pai wrote:
> these changes are mostly fine.
Can you be specific about the exact problems that you noticed that prevented
you from saying "these changes are fine"? It doesn't seem useful to make a
pull request with known deficiencies.
> we usually spl
On Mon, 5 Sep 2022 14:54:50 GMT, Michael Ernst wrote:
> Can you be specific about the exact problems that you noticed that prevented
> you from saying "these changes are fine"?
These changes are fine. I don't see an instance where the duplicated words
would mean a change in the specification.
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Hello Michael,
> > these changes are mostly fine.
>
> Can you be specific about the exact problems that you noticed that prevented
> you from saying "these chan
On Sat, 24 Sep 2022 10:41:05 GMT, Jaikiran Pai wrote:
> Splitting these changes into smaller PRs instead of one big one that touches
> several different areas of the JDK and 108 files, will help reviewers.
OK. I'll repeat my comment from before:
> Feel free to split up the pull request, if yo
On Sun, 25 Sep 2022 16:51:27 GMT, SWinxy wrote:
> Oh no what happened
Oops! Thanks for pointing out the goof. It seems to be fixed now.
It has now been a month since I opened the pull request, and I have responded
to each substantive comment promptly. It would be great to merge this pull
r
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
src/java.base/share/native/libzip/zlib/zlib.h line 756:
> 754:If this is done, the old level and strategy will be applied to the
> data
> 755:compressed
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Oh no what happened
src/java.xml/share/classes/com/
On Tue, 30 Aug 2022 09:31:07 GMT, Alan Bateman wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>
>> 754:If this is done, the old level and strategy will be applied to the
>> data
>> 755:com
On Tue, 30 Aug 2022 09:55:18 GMT, Lance Andersen wrote:
>> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>>
>>> 754:If this is done, the old level and strategy will be applied to the
>>> data
>>> 755:compressed before deflateParams(), and the new level and strategy
>>> will b
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
I'm not a committer (yet) so I can't [sponsor](https://openjdk.org/sponsor/)
this PR, even though I would.
-
PR: https://git.openjdk.org/jdk/pull/10
13 matches
Mail list logo
