Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v6]

2022-09-08 Thread Weijun Wang
On Wed, 7 Sep 2022 23:38:53 GMT, Valerie Peng wrote: >> Existing provider filtering code only handles two standard attribute >> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over >> time, more standard attributes are added which contain multiple values >> separated by "|

Re: RFR: JDK-8291509 Minor cleanup could be done in sun.security [v7]

2022-09-08 Thread Weijun Wang
On Wed, 7 Sep 2022 14:40:23 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8291509 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > comments from Max and Sean This is my last part of code review. Most trivial

Re: RFR: JDK-8291509 Minor cleanup could be done in sun.security [v6]

2022-09-08 Thread Weijun Wang
On Fri, 2 Sep 2022 18:48:32 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8291509 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > white space src/java.base/share/classes/sun/security/ssl/CertificateMessage.

Re: RFR: 5066842: PKCS8EncodedKeySpec needs getAlgorithm method [v2]

2022-09-08 Thread Weijun Wang
On Fri, 2 Sep 2022 08:51:04 GMT, Bernd wrote: >> I want this to be spec from now on. If we want to backport this to older >> releases, then the paragraph above can be @implNote. > > I agree that this should be in the API spec. > > Does the „return null“ case for invalid encodings need to mentio

Re: RFR: 5066842: PKCS8EncodedKeySpec needs getAlgorithm method [v2]

2022-09-08 Thread Weijun Wang
On Fri, 2 Sep 2022 09:11:56 GMT, Bernd wrote: > Should this also be aligned with EncryptedPrivateKeyInfo? `EncryptedPrivateKeyInfo` claims it might return a different more-standard name other than the one provided in a constructor, We don't intend to do it here because of compatibility issue.

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v6]

2022-09-08 Thread Valerie Peng
On Thu, 8 Sep 2022 14:25:06 GMT, Weijun Wang wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More refactoring > > src/java.base/share/classes/java/security/Security.java line 610: > >> 608: // return n

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v6]

2022-09-08 Thread Weijun Wang
On Wed, 7 Sep 2022 23:38:53 GMT, Valerie Peng wrote: >> Existing provider filtering code only handles two standard attribute >> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over >> time, more standard attributes are added which contain multiple values >> separated by "|

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v6]

2022-09-08 Thread Weijun Wang
On Thu, 8 Sep 2022 19:30:57 GMT, Valerie Peng wrote: >> src/java.base/share/classes/java/security/Security.java line 610: >> >>> 608: // return null if the selection criteria is empty; this is >>> to match >>> 609: // earlier behavior >>> 610: return null; >>

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v6]

2022-09-08 Thread Valerie Peng
On Wed, 7 Sep 2022 23:38:53 GMT, Valerie Peng wrote: >> Existing provider filtering code only handles two standard attribute >> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over >> time, more standard attributes are added which contain multiple values >> separated by "|

Integrated: 6447816: Provider filtering (getProviders) is not working with OR'd conditions

2022-09-08 Thread Valerie Peng
On Wed, 24 Aug 2022 20:22:32 GMT, Valerie Peng wrote: > Existing provider filtering code only handles two standard attribute > "KeySize" and "ImplementedIn", the rest are compared by exact match. Over > time, more standard attributes are added which contain multiple values > separated by "|".