Fix compilation with Zc:preprocessor enabled.
The flag itself will be enabled in
[JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the flag
using instructions found in Magnus's comment on that issue.
Windows 10 SDK version 2104 (10.0.20348.0) is required for successful
com
On Fri, 26 Aug 2022 18:30:36 GMT, Rajan Halade wrote:
>> This fix adds Certigna root CA to cacerts trust store.
>
> Rajan Halade has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/reba
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's comment on that issue.
>
> W
On Fri, 12 Aug 2022 18:15:53 GMT, Kevin Driver wrote:
> Fix for JDK-4958071 to add additional @throws stanza to javadocs for all init
> methods
This pull request has now been integrated.
Changeset: 550e5d78
Author:Kevin Driver
Committer: Valerie Peng
URL:
https://git.openjdk.org/j
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
Kevin Driver has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request cont
On Mon, 29 Aug 2022 21:48:18 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291509
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> white space
src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 1
On Mon, 29 Aug 2022 21:48:18 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291509
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> white space
A few more comments.
src/java.base/share/classes/sun/security/
On Tue, 30 Aug 2022 19:31:36 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 1003:
>
>> 1001: * @throws IOExceptio
On Tue, 30 Aug 2022 19:36:55 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> src/java.base/share/classes/sun/security/pkcs/SigningCertificateInfo.java
> line 133:
>
>> 131: pri
On Tue, 30 Aug 2022 19:52:03 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 2319:
>
>> 2317:
On Fri, 12 Aug 2022 17:41:16 GMT, Kevin Driver wrote:
> add @exception message to indicate an NPE might be thrown when the input
> parameter is null
This pull request has now been integrated.
Changeset: 6335150c
Author:Kevin Driver
Committer: Bradford Wetmore
URL:
https://git.open
On Mon, 29 Aug 2022 21:48:18 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291509
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> white space
Files before (and equals to) `X509Factory`.
src/java.base/shar
On Tue, 30 Aug 2022 20:10:43 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> src/java.base/share/classes/sun/security/jca/ProviderList.java line 672:
>
>> 670: "SHA3-384
On Tue, 30 Aug 2022 21:25:25 GMT, Mark Powers wrote:
>> src/java.base/share/classes/sun/security/jca/ProviderList.java line 672:
>>
>>> 670: "SHA3-384", "SHA3-512" };
>>> 671: private static final String[] HmacSHA3Group = { "HmacSHA3-224",
>>> 672: "HmacSHA3-256", "Hm
On Tue, 30 Aug 2022 21:38:26 GMT, Weijun Wang wrote:
>> Why?
>
> http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-constants
Can't argue with that.
-
PR: https://git.openjdk.org/jdk/pull/9972
On Tue, 30 Aug 2022 20:12:19 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> white space
>
> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 216:
>
>> 214:
>> 215: private void p
16 matches
Mail list logo
