Re: RFR: 8133816: Display extra SSLServerSocket info in debug mode [v3]

2022-08-29 Thread Sean Coffey
On Fri, 26 Aug 2022 14:51:48 GMT, Xue-Lei Andrew Fan wrote: >> I think many engineers use the `-Djavax.net.debug=all` option for TLS >> debugging at moment. `-Djavax.net.debug=ssl` is pretty much broke. There's >> an open bug for that IIRC. >> >> I revisited the ServerHello produce() code for

Re: RFR: 8292681: Add JMH for ProtectionDomain [v3]

2022-08-29 Thread Eric Caspole
> Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, > add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed > for this test and will be useful for future class loading JMH too. Eric Caspole has updated the pull request incrementally with one addit

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v4]

2022-08-29 Thread Valerie Peng
> Existing provider filtering code only handles two standard attribute > "KeySize" and "ImplementedIn", the rest are compared by exact match. Over > time, more standard attributes are added which contain multiple values > separated by "|". We should enhance the provider filtering code to better

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v4]

2022-08-29 Thread Weijun Wang
On Mon, 29 Aug 2022 15:42:17 GMT, Valerie Peng wrote: >> Existing provider filtering code only handles two standard attribute >> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over >> time, more standard attributes are added which contain multiple values >> separated by "

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v4]

2022-08-29 Thread Valerie Peng
On Mon, 29 Aug 2022 18:36:20 GMT, Weijun Wang wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove obsolete println. > > src/java.base/share/classes/java/security/Security.java line 872: > >> 870: * and rem

Re: RFR: 6447816: Provider filtering (getProviders) is not working with OR'd conditions [v5]

2022-08-29 Thread Valerie Peng
> Existing provider filtering code only handles two standard attribute > "KeySize" and "ImplementedIn", the rest are compared by exact match. Over > time, more standard attributes are added which contain multiple values > separated by "|". We should enhance the provider filtering code to better

Re: RFR: JDK-8291509 Minor cleanup could be done in sun.security [v2]

2022-08-29 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8291509 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: remove requireNonNull - Changes: - all: https://git.openjdk.org/jdk/pull/9972/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

2022-08-29 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8291509 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: white space - Changes: - all: https://git.openjdk.org/jdk/pull/9972/files - new: https://git.openjdk.org/jdk/pull/9972/file