On Wed, 24 Aug 2022 20:45:29 GMT, Eric Caspole wrote:
>> Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also,
>> add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed
>> for this test and will be useful for future class loading JMH too.
>
> Eric Cas
On Thu, 25 Aug 2022 09:14:07 GMT, Sean Mullan wrote:
>> Eric Caspole has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updates from reviewers comments
>
> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 90:
>
>>
Thanks Franco,
I am very familiar with the IAIK toolkit as our Entrust Java toolkit actually
makes use of the IAIK ASN.1 library from a 2003 version and IAIK and Entrust
used to work very closely together regarding our toolkits in the early 2000's.
So I think between the 3 of us we represent
On Mon, 22 Aug 2022 21:45:39 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8291509
Some initial comments so far.
src/java.base/share/classes/sun/security/jca/ProviderList.java line 129:
> 127: int j = 0;
> 128: for (ProviderConfig config : providerList.configs)
On Thu, 25 Aug 2022 02:59:42 GMT, Valerie Peng wrote:
>> Existing provider filtering code only handles two standard attribute
>> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over
>> time, more standard attributes are added which contain multiple values
>> separated by "
On Thu, 25 Aug 2022 15:00:55 GMT, Sean Mullan wrote:
>> https://bugs.openjdk.org/browse/JDK-8291509
>
> src/java.base/share/classes/sun/security/jca/ProviderList.java line 129:
>
>> 127: int j = 0;
>> 128: for (ProviderConfig config : providerList.configs) {
>> 129: i
On Thu, 25 Aug 2022 14:30:01 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test to use SHA256 and DSA throughout.
>
> src/java.base/share/classes/java/security/Security.java line 599:
>
>
On Wed, 24 Aug 2022 21:59:59 GMT, Xue-Lei Andrew Fan wrote:
>> The cipher suite enabled on the server side is not logged when "no common in
>> cipher suites" error is thrown. Hope the developer could find the difference
>> in the cipher suites between client and server.
>
> Even the cipher suit
On Thu, 25 Aug 2022 14:41:44 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test to use SHA256 and DSA throughout.
>
> src/java.base/share/classes/java/security/Security.java line 945:
>
>
This fix adds Certigna root CA to cacerts trust store.
-
Commit messages:
- remove control-M characters
- Added Certigna CA cert and updated VerifyCACerts.java test
- Merge remote-tracking branch 'origin/master' into 8247698-certigna
- 8247698: Evaluate the inclusion of DHIMYOTIS
On Thu, 25 Aug 2022 20:00:45 GMT, Sean Coffey wrote:
>> Even the cipher suites are the same between client and server, it may still
>> fail with "no common in cipher suites" error. The cause of the bug is not
>> only about "no common in cipher suites" between client and server, but also
>> ab
On Thu, 25 Aug 2022 15:01:28 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test to use SHA256 and DSA throughout.
>
> test/jdk/java/security/Security/ProviderFiltering.java line 89:
>
>>
Happy to offer any assistance I can.
The existing API maps well for key wrapping if you follow the example of
RFC 5990 - the RSA-KEM - but for actual secret sharing, every solution
that "fits", including our current one, doesn't really fit either the
JCA, or the algorithms themselves.
Even
On Thu, 25 Aug 2022 15:06:04 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test to use SHA256 and DSA throughout.
>
> test/jdk/java/security/Security/ProviderFiltering.java line 109:
>
>>
On Thu, 25 Aug 2022 15:25:57 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test to use SHA256 and DSA throughout.
>
> src/java.base/share/classes/java/security/Security.java line 530:
>
>
On Thu, 25 Aug 2022 23:31:53 GMT, Valerie Peng wrote:
>> test/jdk/java/security/Security/ProviderFiltering.java line 109:
>>
>>> 107: filters.put("Signature.SHA256withDSA", "");
>>> 108: doit(filters, p);
>>> 109: filters.put("Cipher.Nonexisting", "");
>>
>> Even if it's
On Thu, 25 Aug 2022 23:54:05 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/java/security/Security.java line 931:
>>
>>> 929: // check individual component for match and bail
>>> if no match
>>> 930: if (prop.indexOf(st.nextToken()) == -1) {
>>>
On Fri, 26 Aug 2022 00:38:36 GMT, Weijun Wang wrote:
>> Yes, I'd expect if multiple sub-values are specified, it means all of them
>> should appear in `prop` in order to be matched. It does raise an interesting
>> question as to how to do the filtering based on an "OR" relationship.
>> Perhaps
On Thu, 25 Aug 2022 21:03:35 GMT, Xue-Lei Andrew Fan wrote:
>> @XueleiFan - I think it's fair to say that the current "no cipher suites in
>> common" exception message is misleading for some scenarios. If not
>> misleading, it's ambiguous. You could be dealing with a simple scenario
>> where
On Thu, 25 Aug 2022 16:00:54 GMT, Rajan Halade wrote:
> This fix adds Certigna root CA to cacerts trust store.
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10030
20 matches
Mail list logo
