On Fri, 19 Aug 2022 21:35:17 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
On Fri, 19 Aug 2022 21:47:00 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 08:33:54 GMT, Jayashree Huttanagoudar
wrote:
>> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
>> line 69:
>>
>>> 67: ByteArrayOutputStream stream = new ByteArrayOutputStream();
>>> 68: PrintStream ps = new PrintStream(strea
On Thu, 18 Aug 2022 14:05:38 GMT, Weibing Xiao wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add or remove the
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 14:56:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 15:15:07 GMT, Weijun Wang wrote:
> The new `setErr` is good.
>
> You still haven't printed out the stack trace when the test fails. I know
> this has not effect on whether the test fails or not. The benefit of it is
> for diagnosis once the test fails. Has I seen a failure,
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Mon, 22 Aug 2022 15:58:49 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 16:07:49 GMT, Weijun Wang wrote:
> Just to clarify, I might have confused the stack trace of the exception
> thrown by the test and the newly printed one thrown inside `LoginContext`. I
> meant the latter, which is captured in `s` and this bug is about its content.
So the p
On Mon, 22 Aug 2022 17:08:09 GMT, Jayashree Huttanagoudar
wrote:
> So the patch should look like :
> ...
Yes. If you decide to print out `s` no matter if success or not, you can move
it out of the if block.
> I tried to execute the test case with this change and I don't see anything
> change
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address jcheck space errors
On Mon, 22 Aug 2022 18:05:26 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 18:05:11 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address jcheck space errors a
On Mon, 22 Aug 2022 18:15:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to upd
On Mon, 22 Aug 2022 18:22:48 GMT, Weijun Wang wrote:
> Please update the copyright line of the test to "Copyright (c) 2022, Red Hat,
> Inc." since this is a new test. No other comment. Thanks for the patience.
Done :)
In fact I have to thank you a lot for such patience to guide me throughout.
On Mon, 22 Aug 2022 18:39:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 18:44:21 GMT, Weijun Wang wrote:
> I've submitted the change to our test servers. Will approve the change once
> the job is finished.
Sure thank you!
-
PR: https://git.openjdk.org/jdk/pull/9159
On Mon, 22 Aug 2022 18:39:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
https://bugs.openjdk.org/browse/JDK-8291509
-
Commit messages:
- Merge
- fourth iteration
- third iteration
- mismerge
- Merge
- second iteration
- first iteration
Changes: https://git.openjdk.org/jdk/pull/9972/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9972&range
On Mon, 22 Aug 2022 19:47:01 GMT, Weijun Wang wrote:
> Approved.
>
> Some tiny comments (sorry for more):
>
> 1. No need to import `Configuration` class now.
>
> 2. No need to import `Paths` class now, or, you can change it to `Path`
> and simplify its reference on line 52.
>
>
> No
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for im
27 matches
Mail list logo
