Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v12]

2022-08-18 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address review comment -

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v13]

2022-08-18 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address errors by bot to the

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v14]

2022-08-18 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - M

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v11]

2022-08-18 Thread Jayashree Huttanagoudar
On Wed, 17 Aug 2022 17:31:50 GMT, Weijun Wang wrote: > The test should ensure the stack trace is included in the debug output. > Please check the content of `s`. Make sure this test succeeds after the code > change and fails before it. I have made an attempt to include what you suggested. I di

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v14]

2022-08-18 Thread Weijun Wang
On Thu, 18 Aug 2022 11:48:01 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request with a new target base >

Re: RFR: 8133816: Display extra SSLServerSocket info in debug mode

2022-08-18 Thread Weibing Xiao
On Wed, 17 Aug 2022 14:25:40 GMT, Xue-Lei Andrew Fan wrote: >> Log the debugging info for server cipher suites when setting javax.net.debug >> == ssl, handshake. > > src/java.base/share/classes/sun/security/ssl/ServerHello.java line 409: > >> 407: if (shc.sslConfig.preferLocalCipher

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v14]

2022-08-18 Thread Weijun Wang
On Thu, 18 Aug 2022 11:48:01 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request with a new target base >

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v11]

2022-08-18 Thread Weijun Wang
On Thu, 18 Aug 2022 13:18:15 GMT, Jayashree Huttanagoudar wrote: >> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java >> line 85: >> >>> 83: byte[] byes = stream.toByteArray(); >>> 84: String s = new String(byes); >>> 85: System.out.printf

Re: RFR: 8133816: Display extra SSLServerSocket info in debug mode

2022-08-18 Thread Weibing Xiao
On Wed, 17 Aug 2022 14:27:15 GMT, Xue-Lei Andrew Fan wrote: >> Log the debugging info for server cipher suites when setting javax.net.debug >> == ssl, handshake. > > src/java.base/share/classes/sun/security/ssl/ServerHello.java line 416: > >> 414: >> 415: List legacySuites = new Li

Re: RFR: 8133816: Display extra SSLServerSocket info in debug mode [v2]

2022-08-18 Thread Weibing Xiao
> Log the debugging info for server cipher suites when setting javax.net.debug > == ssl, handshake. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: add or remove the blank line according to the comments - Changes: - a

Re: RFR: 8133816: Display extra SSLServerSocket info in debug mode [v2]

2022-08-18 Thread Weibing Xiao
On Wed, 17 Aug 2022 14:27:56 GMT, Xue-Lei Andrew Fan wrote: >> Weibing Xiao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add or remove the blank line according to the comments > > src/java.base/share/classes/sun/security/ssl/ServerHel

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-18 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address review comments

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-18 Thread Jayashree Huttanagoudar
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >

Integrated: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used

2022-08-18 Thread Weijun Wang
On Wed, 27 Jul 2022 23:02:03 GMT, Weijun Wang wrote: > Add an `@implNote` to clarify the behavior when these methods are called. A > new test is added. This pull request has now been integrated. Changeset: 54ce1143 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/54ce1143

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-18 Thread Weijun Wang
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >