On Mon, 15 Aug 2022 15:58:50 GMT, Weijun Wang wrote:
> System.setErr
Looks like call stack info of the exception is not produced for OPTIONAL login
module when debug is on. Here :
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/javax/security/auth/login/LoginContext.java
On Mon, 8 Aug 2022 17:34:59 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for te
On Tue, 16 Aug 2022 08:44:03 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for cr
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Tue, 16 Aug 2022 14:17:43 GMT, Weijun Wang wrote:
> Why the new change? The bug is about an optional LoginModule failure not
> logged, and it only happens when there are multiple login modules and the
> overall login succeeds.
Hmm then I misunderstood your previous comment :
>In the "cross-
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote:
>> Looks good to me. Thanks!
>
>> Looks good to me. Thanks!
>
> Cheers and appreciation! And I have learned more from your guidance.
@jquanC Please type`/integrate` if you want to get the fix included in OpenJDK.
-
PR: https://git.o
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Tue, 16 Aug 2022 14:32:46 GMT, Weijun Wang wrote:
> The original "cross-platform" case is exactly what this bug is about. The
> overall login succeeds but the reason of the optional login module failure is
> not logged in the debug output. You need to update the source code of
> `LoginConte
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote:
>> Looks good to me. Thanks!
>
>> Looks good to me. Thanks!
>
> Cheers and appreciation! And I have learned more from your guidance.
> @jquanC Please type`/integrate` if you want to get the fix included in
> OpenJDK.
Thanks for your reminder!
I
On Thu, 21 Jul 2022 08:53:31 GMT, jquanC wrote:
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string ta
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Tue, 16 Aug 2022 14:50:11 GMT, Weijun Wang wrote:
> > Ok. But the change what I had for LoginContext.java in this commit was not
> > appropriate :
> > [13a51a6](https://github.com/openjdk/jdk/commit/13a51a6d2e026225ec8ac9f1516c7f709c72ce08)
> > right?
>
> No. If you only put the reason ins
On Tue, 16 Aug 2022 14:57:06 GMT, Jayashree Huttanagoudar
wrote:
> That means in the source code here:
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/javax/security/auth/login/LoginContext.java#L881
> ?
Yes.
-
PR: https://git.openjdk.org/jdk/pull/9159
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to rev
16 matches
Mail list logo
