Re: RFR: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s) [v2]

2022-08-08 Thread Alan Bateman
On Fri, 5 Aug 2022 09:54:36 GMT, Peter Levart wrote: >> This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s) >> when used internally in JDK for per-carrier-thread caches of native >> ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such >> TerminatingThre

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v3]

2022-08-08 Thread Jayashree Huttanagoudar
On Thu, 4 Aug 2022 01:40:36 GMT, Weijun Wang wrote: > BTW, have you reverted your change on `LoginContext.java`. I remembered we > agreed that this bug is all about debug info instead of updating the > exception thrown. Actually here: https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%

RFR: 8155246: Throw error if default java.security file is missing

2022-08-08 Thread Sean Coffey
In the broken case where the conf/security/java.security configuration file doesn't exist, the JDK should throw an Error. CSR in progress. - Commit messages: - Update bug summary in test - 8155246 Changes: https://git.openjdk.org/jdk/pull/9747/files Webrev: https://webrevs.open

Integrated: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)

2022-08-08 Thread Peter Levart
On Thu, 4 Aug 2022 10:57:53 GMT, Peter Levart wrote: > This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s) > when used internally in JDK for per-carrier-thread caches of native > ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such > TerminatingThreadLo

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v4]

2022-08-08 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address review comments

Integrated: JDK-8290975 Minor cleanup could be done in javax.security

2022-08-08 Thread Mark Powers
On Wed, 27 Jul 2022 20:24:19 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290975 This pull request has now been integrated. Changeset: 08274e6f Author:Mark Powers Committer: Bradford Wetmore URL: https://git.openjdk.org/jdk/commit/08274e6fea982e71ccc5964f4919c6550

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v5]

2022-08-08 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Added test case using {Unix,N

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v3]

2022-08-08 Thread Jayashree Huttanagoudar
On Mon, 8 Aug 2022 08:42:11 GMT, Jayashree Huttanagoudar wrote: > > BTW, have you reverted your change on `LoginContext.java`. I remembered we > > agreed that this bug is all about debug info instead of updating the > > exception thrown. > > Actually here: > https://bugs.openjdk.org/browse/J

Re: RFR: 8155246: Throw error if default java.security file is missing

2022-08-08 Thread Anthony Scarpino
On Thu, 4 Aug 2022 15:22:23 GMT, Sean Coffey wrote: > In the broken case where the conf/security/java.security configuration file > doesn't exist, the JDK should throw an Error. > > CSR in progress. What's the need for this change? Perhaps I'm missing the bigger problem here. Certainly not

Re: RFR: 8155246: Throw error if default java.security file is missing

2022-08-08 Thread Sean Coffey
On Thu, 4 Aug 2022 15:22:23 GMT, Sean Coffey wrote: > In the broken case where the conf/security/java.security configuration file > doesn't exist, the JDK should throw an Error. > > CSR in progress. Hi Tony, there are a few points for the change IMO: * The fall back to the "static" security

Re: PKCS8 with PBES2 protection supported by EncryptedPrivateKeyInfo?

2022-08-08 Thread Anthony Scarpino
Hi, I did this not long ago. You are close, but you do not need to do the Cipher.init() separately, it is done as part of EncryptedPrivateKeyInfo.getKeySpec(). It also reads the encoding for the count and iv. The below will decrypt the DER-encoded 'data' into a PKCS8EncryptedKeySpec for yo

Re: PKCS8 with PBES2 protection supported by EncryptedPrivateKeyInfo?

2022-08-08 Thread Anthony Scarpino
Oops.. I think I suggested something that only works in my development repo with PBES2. I ran you code and it worked on jdk-dev. Other than setting -v2 on the 'openssl pkcs8' cmdline, en javax.crypto.EncryptedPrivateKeyInfo@46d56d67 alg=PBEWithHmacSHA1AndAES_256 p=PBEWithHmacSHA1AndAES_256