Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

2022-08-01 Thread Naoto Sato
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added comments in CurrencyNames root in base, moved US CurrencyNames back > t

Re: RFR: 8245527: LDAP Channel Binding support for Java GSS/Kerberos [v2]

2022-08-01 Thread Neustradamus
On Tue, 22 Sep 2020 20:19:21 GMT, Alexey Bakhtin wrote: >> Hi, >> >> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support >> for Java GSS/Kerberos. >> Initial review is available at core-devs: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.ht

Integrated: 8282730: LdapLoginModule throw NPE from logout method after login failure

2022-08-01 Thread Weijun Wang
On Fri, 1 Jul 2022 17:31:06 GMT, Weijun Wang wrote: > Add null-checks in all `LoginModule` implementations. It's possible that an > application calls `logout` after a login failure, where most internal > variables for principals and credentials are null and removing a null from > the `Subject`

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v3]

2022-08-01 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address review comment to cha