Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops [v2]

2022-07-25 Thread Сергей Цыпанов
On Mon, 25 Jul 2022 06:40:49 GMT, Сергей Цыпанов wrote: >> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8278461: Revert X509CertPath I've m

Withdrawn: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-25 Thread Сергей Цыпанов
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote: > We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9596

Re: RFR: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath

2022-07-25 Thread Andrey Turbanov
On Thu, 23 Jun 2022 19:32:44 GMT, Andrey Turbanov wrote: > Use `InputStream.readAllBytes` instead of manually written method. > > Skipped this method in > [JDK-8080272](https://bugs.openjdk.org/browse/JDK-8080272) I think we need approve from security team. @seanjmullan @wangweij can you pleas

Re: RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v2]

2022-07-25 Thread Guzhenyuan
On Tue, 30 Nov 2021 23:03:42 GMT, Valerie Peng wrote: > > Consider this case, two threads are changing a value at the same time. > > Since the method is not synchonized, thread1 might finish the first part of > > the method (`super.replace`) earlier than thread2, but it finishes the > > second

Re: RFR: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath

2022-07-25 Thread Weijun Wang
On Thu, 23 Jun 2022 19:32:44 GMT, Andrey Turbanov wrote: > Use `InputStream.readAllBytes` instead of manually written method. > > Skipped this method in > [JDK-8080272](https://bugs.openjdk.org/browse/JDK-8080272) Looks good to me. Thanks. - Marked as reviewed by weijun (Reviewer

Re: RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v2]

2022-07-25 Thread Weijun Wang
On Mon, 25 Jul 2022 08:55:30 GMT, Guzhenyuan wrote: > Can you tell me which version of jdk fixes these bugs You mean *this* bug? Click on the "Issue" link and you can it was included in JDK 18. - PR: https://git.openjdk.org/jdk/pull/6513

Integrated: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath

2022-07-25 Thread Andrey Turbanov
On Thu, 23 Jun 2022 19:32:44 GMT, Andrey Turbanov wrote: > Use `InputStream.readAllBytes` instead of manually written method. > > Skipped this method in > [JDK-8080272](https://bugs.openjdk.org/browse/JDK-8080272) This pull request has now been integrated. Changeset: 0ca74f53 Author:Andre

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-25 Thread Naoto Sato
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. Changes requested by naoto (Reviewer). src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-25 Thread Alexey Semenyuk
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. Why `MSG_Help_mac_launcher` in [src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties](https://github.com/openjdk/jdk19/pull/154/files#diff-2e1b121e201e1040827d5b6

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-25 Thread Valerie Peng
On Fri, 22 Jul 2022 10:22:39 GMT, Matthias Baesken wrote: >> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the >> following PKCS11 exception (see attached jtr files of that bug) : >> >> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 >> >> Unf

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-25 Thread Valerie Peng
On Fri, 22 Jul 2022 10:22:40 GMT, Matthias Baesken wrote: > Hi Valerie that sounds like a good idea, I adjusted the PR . Have you verified the new output and see if it addresses your need? I will also run the regression tests just to be safe. Thanks~ - PR: https://git.openjdk.org/