Re: [Internet]Re: SSLExtension: Bug/typo in unsupported extension

2022-06-21 Thread Ben Smyth
Thanks Jaikiran. Since RFC 7250 &7685 are unsupported, this isn't particularly significant. (I discovered whilst looking for raw public key support.) On Tue, 21 Jun 2022 at 07:51, Jaikiran Pai wrote: > > On 20/06/22 9:05 pm, Ben Smyth wrote: > > On Mon, 20 Jun 2022 at 17:00, xueleifan(XueleiFan)

Re: [Internet]Re: SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread Jaikiran Pai
On 20/06/22 9:05 pm, Ben Smyth wrote: On Mon, 20 Jun 2022 at 17:00, xueleifan(XueleiFan) I see.  The Github repository is used now, and the hg repository above may be discontinued. Thanks for the clarification Xuelei, I'll be sure to use Github. On Mon, 20 Jun 2022 at 17:23, Jaikiran

Re: [Internet]Re: SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread Ben Smyth
On Mon, 20 Jun 2022 at 17:00, xueleifan(XueleiFan) > I see. The Github repository is used now, and the hg repository above may > be discontinued. > Thanks for the clarification Xuelei, I'll be sure to use Github. On Mon, 20 Jun 2022 at 17:23, Jaikiran Pai > Do you have a JBS account so that yo

Re: [Internet]SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread Jaikiran Pai
Hello Ben, Like Xuelei noted in his reply, the latest upstream JDK mainline code has the necessary fix for this issue. The fix seems to have been done as part of some other bigger changes (in Java 16). What you discovered is still an issue in versions previous to that (specifically Java 8 and

Re: [Internet]Re: SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread xueleifan(XueleiFan)
On Jun 20, 2022, at 7:38 AM, Ben Smyth mailto:subscripti...@bensmyth.com>> wrote: Xuelei, You're right, OpenJDK/jdk GitHub is correct. I was looking at hg.openjdk.java.net/jdk/jdk, specifically https://hg.openjdk.java.net/jdk/jdk/file/ee1d592a9f53/src/

Re: [Internet]SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread Ben Smyth
Xuelei, You're right, OpenJDK/jdk GitHub is correct. I was looking at hg.openjdk.java.net/jdk/jdk, specifically https://hg.openjdk.java.net/jdk/jdk/file/ee1d592a9f53/src/java.base/share/classes/sun/security/ssl/SSLExtension.java Ben On Mon, 20 Jun 2022 at 16:19, xueleifan(XueleiFan) wrote:

Re: [Internet]SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread xueleifan(XueleiFan)
Would you mind post the source code or the repository link? It looks like the code

SSLExtension: Bug/typo in unsupported extension

2022-06-20 Thread Ben Smyth
We have // extensions defined in RFC 7250 CLIENT_CERT_TYPE(0x0013, "padding"), SERVER_CERT_TYPE(0x0014, "server_certificate_type"), // extensions defined in RFC 7685 PADDING (0x0015, "client_certificate_type"), We should have // extensions