On Mon, 2 Jun 2025 11:10:04 GMT, Aleksey Shipilev wrote:
> SonarCloud complains we are using the String.replaceAll() method that creates
> Pattern internally every time. This looks a minor inefficiency in preview
> feature, but we can fix it from the day 1. Also fixed the variable name style
>
On Mon, 2 Jun 2025 11:10:04 GMT, Aleksey Shipilev wrote:
> SonarCloud complains we are using the String.replaceAll() method that creates
> Pattern internally every time. This looks a minor inefficiency in preview
> feature, but we can fix it from the day 1. Also fixed the variable name style
>
On Mon, 2 Jun 2025 11:10:04 GMT, Aleksey Shipilev wrote:
> SonarCloud complains we are using the String.replaceAll() method that creates
> Pattern internally every time. This looks a minor inefficiency in preview
> feature, but we can fix it from the day 1. Also fixed the variable name style
>
On Mon, 2 Jun 2025 11:10:04 GMT, Aleksey Shipilev wrote:
> SonarCloud complains we are using the String.replaceAll() method that creates
> Pattern internally every time. This looks a minor inefficiency in preview
> feature, but we can fix it from the day 1. Also fixed the variable name style
>
On Mon, 2 Jun 2025 16:53:54 GMT, Anthony Scarpino wrote:
> looks good
Thanks! A bit blurry on review rules in this area: do you want me to wait for
someone else to review? More tests to run?
-
PR Comment: https://git.openjdk.org/jdk/pull/25583#issuecomment-2931591245
