Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-20 Thread Bradford Wetmore
On Tue, 18 Feb 2025 17:28:21 GMT, Sean Mullan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Further codereview Comments from Weijun > > src/java.base/share/classes/javax/crypto/KEM.java line 68: > >> 66: *

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-18 Thread Sean Mullan
On Sat, 15 Feb 2025 22:33:46 GMT, Bradford Wetmore wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >>

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-15 Thread Weijun Wang
On Sat, 15 Feb 2025 22:33:46 GMT, Bradford Wetmore wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >>

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-15 Thread Bradford Wetmore
> The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > Added/tweaked example for clarity. > > Generated/checked jav

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v2]

2025-02-15 Thread Bradford Wetmore
> The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > Added/tweaked example for clarity. > > Generated/checked jav

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Bradford Wetmore
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >> >> A

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Bradford Wetmore
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >> >> A

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Weijun Wang
On Sat, 15 Feb 2025 05:02:44 GMT, Bradford Wetmore wrote: > The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > A