Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-04-07 Thread duke
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull requ

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-04-07 Thread Mikhail Yankelevich
On Fri, 4 Apr 2025 14:24:09 GMT, Sean Mullan wrote: > The JBS issue should have a `noreg-self` label. Otherwise fix looks ok. @seanjmullan thank you! I have updated the JBS issue. - PR Comment: https://git.openjdk.org/jdk/pull/23440#issuecomment-2782500576

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-04-05 Thread Mikhail Yankelevich
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull requ

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-04-04 Thread Sean Mullan
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull requ

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-03-11 Thread Jaikiran Pai
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull requ

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

2025-03-11 Thread Mikhail Yankelevich
On Thu, 6 Mar 2025 11:20:23 GMT, Jaikiran Pai wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-03-06 Thread Mikhail Yankelevich
On Thu, 6 Mar 2025 12:40:17 GMT, Jaikiran Pai wrote: > Thank you for the updates, Mikhail. This looks good to me. Given the > background of these tests, please have it approved from security-libs team > too before integrating. Thank you - PR Comment: https://git.openjdk.org/jdk/p

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-03-06 Thread Mikhail Yankelevich
> Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

2025-03-06 Thread Mikhail Yankelevich
On Thu, 6 Mar 2025 11:21:38 GMT, Jaikiran Pai wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

2025-03-06 Thread Jaikiran Pai
On Thu, 27 Feb 2025 17:49:48 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull req

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-28 Thread Jaikiran Pai
On Thu, 27 Feb 2025 16:08:09 GMT, Jaikiran Pai wrote: > Hello Mikhail, since we are updating these tests to move away from the shell > tests, could you also see if the deadlock.jar file which has been committed > into the repo, can be generated dynamically within the test itself. I spoke to M

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

2025-02-27 Thread Mikhail Yankelevich
> Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The increment

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Jaikiran Pai
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote: > Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh Hello Mikhail, since we are updating these tests to

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Mikhail Yankelevich
On Thu, 27 Feb 2025 15:37:47 GMT, Matthew Donovan wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > test/jdk/java/security/Security/ClassLoaderDeadlo

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Matthew Donovan
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote: > Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh test/jdk/java/security/Security/ClassLoaderDeadlock/