Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v2]

2025-02-25 Thread Anthony Scarpino
On Fri, 21 Feb 2025 21:03:40 GMT, Sean Mullan wrote: >> I stayed away from that because this is likely being backported > > Ok, well our backporters are usually good about extracting only what is > necessary, but if not, can you file another issue to add support for > disabling PQC algorithms?

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v2]

2025-02-25 Thread Anthony Scarpino
On Tue, 25 Feb 2025 14:46:11 GMT, Artur Barashev wrote: >> Anthony Scarpino has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - undo comment >> - review comments and remove aliases > > src/java.base/share/classes/sun/security/util/Abstrac

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v2]

2025-02-25 Thread Artur Barashev
On Mon, 24 Feb 2025 21:25:48 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for the following change. Naming conventions for EdDSA and >> XDH have inconsistencies between DisabledAlgorithms and KeyPairGenerator. >> These internal changes help make it more consistent when parsing th

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v2]

2025-02-24 Thread Anthony Scarpino
> Hi, > > I need a review for the following change. Naming conventions for EdDSA and > XDH have inconsistencies between DisabledAlgorithms and KeyPairGenerator. > These internal changes help make it more consistent when parsing the actual > curve being used vs the broader algorithm name. > > t