Re: RFR: 8344419: Use StaticProperty in some JDK classes

2024-11-25 Thread Roger Riggs
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote: > This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22214#pullreq

Re: RFR: 8344419: Use StaticProperty in some JDK classes

2024-11-25 Thread Alan Bateman
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote: > This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. Marked as reviewed by alanb (Reviewer). Updated change looks okay. The CDS method is only invoked at dump time so

Re: RFR: 8344419: Use StaticProperty in some JDK classes

2024-11-25 Thread Alan Bateman
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote: > This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java line 52: > 50: > 51: private static