Re: RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-25 Thread Weijun Wang
On Thu, 25 Jul 2024 19:04:12 GMT, Hai-May Chao wrote: > Nice to have new PoC.java test to cover indefinite length encoding. Looks > good. The other test -- from the bug reporter -- also contains indefinite length encoding deep inside, but the `PoC.java` test makes it more obvious what goes wr

Re: RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-25 Thread Hai-May Chao
On Mon, 22 Jul 2024 21:28:07 GMT, Weijun Wang wrote: > When reading an indefinite BER `DerValue` from a `DerInputStream`, the > current position of the stream must be placed right after the BER. There is a > bug in the calculation. Nice to have new PoC.java test to cover indefinite length enco

Re: RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-25 Thread Valerie Peng
On Mon, 22 Jul 2024 21:28:07 GMT, Weijun Wang wrote: > When reading an indefinite BER `DerValue` from a `DerInputStream`, the > current position of the stream must be placed right after the BER. There is a > bug in the calculation. Look good. Thanks~ - Marked as reviewed by valer

Re: RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-24 Thread Valerie Peng
On Mon, 22 Jul 2024 21:28:07 GMT, Weijun Wang wrote: > When reading an indefinite BER `DerValue` from a `DerInputStream`, the > current position of the stream must be placed right after the BER. There is a > bug in the calculation. I will take a look. - PR Comment: https://git.op