Re: RFR: 8333754: Add a Test against ECDSA and ECDH NIST Test vector

2024-06-18 Thread Anthony Scarpino
On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote: > Tests added against ECDSA and ECDH NIST Test vector. The changes look good to me. - Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19715#pullrequestreview-2126732468

Re: RFR: 8333754: Add a Test against ECDSA and ECDH NIST Test vector

2024-06-13 Thread Sibabrata Sahoo
On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote: > Tests added against ECDSA and ECDH NIST Test vector. test/jdk/sun/security/ec/ECDSAPrimitive.java line 255: > 253: MutablePoint R = ecOps.multiply(publicKeyPoint, u2Bytes); > 254: AffinePoint a1 = ops.basePointMultiply(u

Re: RFR: 8333754: Add a Test against ECDSA and ECDH NIST Test vector

2024-06-13 Thread Sibabrata Sahoo
On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote: > Tests added against ECDSA and ECDH NIST Test vector. test/jdk/sun/security/ec/ECDHPrimitive.java line 33: > 31: import javax.crypto.*; > 32: > 33: import jdk.test.lib.Asserts; Usage of Asserts and removed corresponding local code tes