Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 15:04:20 GMT, Sean Mullan wrote: >> Do we need to mention "at the same time" because it's thread-safe? > > Yes, how about: "The `deriveKey` and `deriveData` methods of `KDF` objects > must be thread-safe. That is, multiple threads may concurrently invoke these > methods on a

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 13:57:10 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 395: >> >>> 393: * >>> 394: * The {@code deriveKey} method may be called multiple times once a >>> 395: * {@code KDF} object is initialized. >> >> I think this sentence

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Weijun Wang
On Sun, 12 May 2024 14:43:04 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> commenting out until better understood -- causing failures > > src/java.base/share/classes/javax/crypto/KDF.java line 39

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Sun, 12 May 2024 18:13:37 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 398: >> >>> 396: * >>> 397: * Delayed provider selection is also supported such that the >>> provider >>> 398: * performing the derive is not selected until the method

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Weijun Wang
On Sun, 12 May 2024 14:39:40 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> commenting out until better understood -- causing failures > > src/java.base/share/classes/javax/crypto/KDF.java line 39

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Weijun Wang
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Sean Mullan
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-10 Thread Alan Bateman
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-10 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the