Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Sean Mullan
On Tue, 23 Apr 2024 09:05:25 GMT, Oli Gillespie wrote: > > Please don't integrate until a Reviewer from the Security Group has > > reviewed this. Thanks. > > @seanjmullan are you okay for me to integrate now? Yes, @ascarpino has reviewed it and he is a Reviewer in the Security Group.

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Oli Gillespie
On Fri, 12 Apr 2024 16:19:56 GMT, Sean Mullan wrote: > Please don't integrate until a Reviewer from the Security Group has reviewed > this. Thanks. @seanjmullan are you okay for me to integrate now? - PR Comment: https://git.openjdk.org/jdk/pull/18763#issuecomment-2071793073

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Aleksey Shipilev
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-22 Thread Sean Mullan
On Fri, 19 Apr 2024 09:09:56 GMT, Oli Gillespie wrote: > Thanks :) - created release note at > https://bugs.openjdk.org/browse/JDK-8330632, please review if you can. Looks fine. You can mark it as Resolved/Delivered after the fix is integrated. - PR Comment: https://git.openjdk.or

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-19 Thread Oli Gillespie
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Sean Mullan
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Anthony Scarpino
On Sat, 13 Apr 2024 01:25:57 GMT, David Schlosnagle wrote: > Should the buffer size be a configurable constructor parameter? This would > allow consumers to adjust the buffer size to match their tradeoffs of memory > vs throughput based on workload & available resources, and provide a bit of >

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Anthony Scarpino
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-16 Thread Oli Gillespie
On Mon, 15 Apr 2024 19:34:18 GMT, Anthony Scarpino wrote: >> Can you provide memory usage difference between the current and your >> suggested change with `-prof gc`? With many of these situations, it's a >> balance between memory usage and performance. > >> @ascarpino here's the `-prof gc` r

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-15 Thread Anthony Scarpino
On Fri, 12 Apr 2024 16:49:49 GMT, Anthony Scarpino wrote: >> Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. >> >> I have seen applications where this small buffer size significantly reduces >> throughput, and I've even seen applications which use reflection to modify

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-15 Thread Oli Gillespie
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-15 Thread Oli Gillespie
On Fri, 12 Apr 2024 16:49:49 GMT, Anthony Scarpino wrote: >> Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. >> >> I have seen applications where this small buffer size significantly reduces >> throughput, and I've even seen applications which use reflection to modify

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-12 Thread David Schlosnagle
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-12 Thread Anthony Scarpino
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-12 Thread Sean Mullan
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu