Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-03-07 Thread Sean Mullan
On Fri, 7 Mar 2025 19:31:47 GMT, Sean Mullan wrote: >> I’m not suggesting any source changes, but this documentation update >> explicitly states: >>> Sub-options are specified by appending a ":" to the option, followed by a >>> list of one more sub-options separated by a comma. >> >> This brea

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-03-07 Thread Sean Mullan
On Fri, 7 Mar 2025 19:23:42 GMT, Weijun Wang wrote: >> I think we should look into it. I think we can handle this as a follow-on >> bug so that we keep this issue just about the docs. > > I’m not suggesting any source changes, but this documentation update > explicitly states: >> Sub-options ar

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-03-07 Thread Weijun Wang
On Fri, 7 Mar 2025 17:19:46 GMT, Sean Mullan wrote: >> Anyone still cares about this comment? >> >> I've tried `-Djava.security.debug=certpath:ocsp,verbose+timestamp` (which >> follows the grammar in this PR) and there is no timestamp shown. Obviously, >> it's broken into `certpath:ocsp` and `

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-03-07 Thread Sean Mullan
On Fri, 7 Mar 2025 15:46:18 GMT, Weijun Wang wrote: >> I'd probably have to point to the CSR that introduced the +thread, >> +timestamp options : >> https://bugs.openjdk.org/browse/JDK-8327569 >> >> The "+" symbol should directly follow a valid debug option to be legitimate >> IMO. It's probab

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-03-07 Thread Weijun Wang
On Tue, 25 Feb 2025 19:37:54 GMT, Sean Coffey wrote: >> src/java.base/share/classes/java/security/doc-files/security-related-system-properties.html >> line 68: >> >>> 66: system property to print additional information: >>> 67: >>> 68: +thread:Print thread and caller information >> >>

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-28 Thread Koushik Muthukrishnan Thirupattur
On Fri, 28 Feb 2025 21:30:14 GMT, Sean Mullan wrote: >> Ok, so I don't like "Security-Related System Property" because you would not >> need a title like that for one property. The overall intent of this document >> is to use it as a place to document more system properties, but if we have >>

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-28 Thread Sean Mullan
On Tue, 25 Feb 2025 22:35:56 GMT, Sean Mullan wrote: >> This was the title recommended by Sean above as we want to initially create >> this file for security related system properties. We are going to be adding >> more to it later as needed like he mentioned but for now we will just have >> th

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-25 Thread Sean Mullan
On Tue, 25 Feb 2025 18:50:44 GMT, Koushik Muthukrishnan Thirupattur wrote: >> src/java.base/share/classes/java/security/doc-files/security-related-system-properties.html >> line 29: >> >>> 27: >>> 28: >>> 29: Security-Related System Property >> >> Not what I expected. Either you kee

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-25 Thread Sean Coffey
On Tue, 25 Feb 2025 15:32:07 GMT, Weijun Wang wrote: >> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with one additional commit since the last revision: >> >> 8328914: Document the java.security.debug property in javadoc > > src/java.base/share/classes/java/

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-25 Thread Koushik Muthukrishnan Thirupattur
On Tue, 25 Feb 2025 15:23:20 GMT, Weijun Wang wrote: >> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with one additional commit since the last revision: >> >> 8328914: Document the java.security.debug property in javadoc > > src/java.base/share/classes/java/

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-25 Thread Weijun Wang
On Tue, 25 Feb 2025 00:29:35 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> ![image](https://github.com/user-attachments/assets/0c9a79f3-4c

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-25 Thread Weijun Wang
On Tue, 25 Feb 2025 00:29:35 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> ![image](https://github.com/user-attachments/assets/0c9a79f3-4c

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v9]

2025-02-24 Thread Koushik Muthukrishnan Thirupattur
> java.security.debug is a widely used debug system property for JDK security > libs. It's time to capture details about this property via javadoc. > > ![image](https://github.com/user-attachments/assets/f36a1d8c-3026-4a72-a9e8-b2ecdbf9ed42) > > > NOTE : We are adding a new html file (similar t