Re: RFR: 8322766: Micro bench SSLHandshake should use default algorithms [v2]

2024-01-03 Thread John Jiang
On Sat, 30 Dec 2023 09:20:59 GMT, Daniel Jeliński wrote: >> John Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use default algorithms > > Thanks. Users usually use the default algorithms, so benchmarking them is > probably more

Re: RFR: 8322766: Micro bench SSLHandshake should use default algorithms [v2]

2024-01-03 Thread Daniel Jeliński
On Sat, 30 Dec 2023 00:48:00 GMT, John Jiang wrote: >> test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using >> keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm >> `SunX509`. >> It may be better to use `PKCS12` and `PKIX` respectively. > > John Jiang has u

Re: RFR: 8322766: Micro bench SSLHandshake should use default algorithms [v2]

2024-01-02 Thread John Jiang
On Tue, 2 Jan 2024 13:43:27 GMT, Sean Mullan wrote: >> John Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use default algorithms > > Can you change the bug summary to "Micro bench SSLHandshake should use modern > algorithms"? @