Re: RFR: 8319651: Several network tests ignore vm flags when start java process [v2]

2024-02-16 Thread Darragh Clarke
> Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and > `test/jdk/java/net/URLConnection/6212146/TestDri

Re: RFR: 8319651: Several network tests ignore vm flags when start java process [v2]

2024-02-16 Thread Jaikiran Pai
On Fri, 16 Feb 2024 11:27:52 GMT, Darragh Clarke wrote: >> Currently these tests ignore vm flags, In most cases I've updated them to >> use `ProcessTools.createTestJavaProcessBuilder` this usually required some >> cleanup also. >> >> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLea

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-16 Thread Darragh Clarke
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-15 Thread Jaikiran Pai
On Thu, 15 Feb 2024 12:44:10 GMT, Daniel Fuchs wrote: >> Hello Darragh, Daniel, >> >> As for introducing a new method on `ProcessTools` class, I don't know if >> it's needed - I feel that the `ProcessTools` class is already getting too >> complex because of the various similarly named methods.

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-15 Thread Daniel Fuchs
On Thu, 15 Feb 2024 12:04:27 GMT, Jaikiran Pai wrote: >> That's not a bad idea. What I would recommend in that case would be to not >> do anything here - but rather log another issue against >> `ProcessTools.createTestJavaProcessBuilder`. >> Then proceed with this PR without changing anything.

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-15 Thread Jaikiran Pai
On Mon, 12 Feb 2024 12:51:50 GMT, Daniel Fuchs wrote: >> Would it be possible to change the `createJavaProcessBuilder` method in >> ProcessTools to include something to check if -cp is already an argument >> being passed? >> >> maybe something like this? >> >> >> if (!noCP && !args.contains(

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-15 Thread Jaikiran Pai
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-14 Thread Daniel Fuchs
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-14 Thread Andrey Turbanov
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-12 Thread Daniel Fuchs
On Mon, 12 Feb 2024 10:58:45 GMT, Darragh Clarke wrote: >> test/jdk/java/net/URLClassLoader/getresourceasstream/TestDriver.java line 63: >> >>> 61: ), >>> 62: ProcessTools.createTestJavaProcessBuilder( >>> 63: "-cp", ".", >> >> If I'm not

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-12 Thread Darragh Clarke
On Fri, 9 Feb 2024 12:48:48 GMT, Daniel Fuchs wrote: >> Currently these tests ignore vm flags, In most cases I've updated them to >> use `ProcessTools.createTestJavaProcessBuilder` this usually required some >> cleanup also. >> >> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.j

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-09 Thread Daniel Fuchs
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java