On Fri, 27 Oct 2023 18:33:23 GMT, Weijun Wang wrote:
>> 8318983: Fix comment typo in PKCS12Passwd.java
>
> Thanks for coming back! The jcheck failure ~above~below suggests you rewrite
> the title to something like "8318983: Fix comment typo in PKCS12Passwd.java".
> You can also read the title o
On Mon, 3 Jul 2023 20:12:47 GMT, Gregor Purdy wrote:
> 8318983: Fix comment typo in PKCS12Passwd.java
The change looks good. You can type the `/integrate` command now.
-
Marked as reviewed by weijun (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14762#pullrequestreview-17
On Fri, 27 Oct 2023 14:04:02 GMT, Weijun Wang wrote:
> Sorry about not noticing this earlier. I've filed
> https://bugs.openjdk.org/browse/JDK-8318983. Please update the PR title.
Thanks @wangweij! I added a suffix "; FIXES: JDK-8318983" to the title. Hope
that helps.
-
PR Commen
On Mon, 3 Jul 2023 20:12:47 GMT, Gregor Purdy wrote:
> 8318983: Fix comment typo in PKCS12Passwd.java
Sorry about not noticing this earlier. I've filed
https://bugs.openjdk.org/browse/JDK-8318983. Please update the PR title.
Thanks for coming back! The jcheck failure ~above~below suggests you
On Mon, 3 Jul 2023 20:12:47 GMT, Gregor Purdy wrote:
> 8318983: Fix comment typo in PKCS12Passwd.java
I tried filing an issue to reference but could not.
Could someone please help get this PR merged?
Could someone with the ability to file an issue or bypass that requirement
please help?
@mdi
