Re: RFR: 8318756 Create better internal buffer for AEADs [v4]

2023-12-06 Thread Anthony Scarpino
On Wed, 6 Dec 2023 07:24:08 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update > > src/java.base/share/classes/com/sun/crypto/provider/AEADBufferedStream.java > line 60: > >> 58:

Re: RFR: 8318756 Create better internal buffer for AEADs [v4]

2023-12-05 Thread Daniel Jeliński
On Wed, 6 Dec 2023 03:07:54 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.

Re: RFR: 8318756 Create better internal buffer for AEADs [v4]

2023-12-05 Thread Anthony Scarpino
> Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java > and ChaCha20Cipher.java need. > > The changes greates