Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v3]

2023-10-25 Thread Weijun Wang
> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all > current and future public and private keys. > > No test. Might add one. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: AsymmetricKey - Change

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v2]

2023-10-18 Thread David M . Lloyd
On Wed, 18 Oct 2023 18:23:31 GMT, Weijun Wang wrote: > > Would `getParameterSpec` be a better/more descriptive name, given that the > > thing it returns is an `AlgorithmParameterSpec`? > > > > > > (Disclosure: Our security library (WildFly Elytron) has a > > `getParameterSpec` on every one o

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v2]

2023-10-18 Thread Weijun Wang
On Wed, 18 Oct 2023 04:44:07 GMT, David M. Lloyd wrote: > Would `getParameterSpec` be a better/more descriptive name, given that the > thing it returns is an `AlgorithmParameterSpec`? > > (Disclosure: Our security library (WildFly Elytron) has a `getParameterSpec` > on every one of its key imp

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v2]

2023-10-17 Thread David M . Lloyd
On Tue, 17 Oct 2023 19:48:26 GMT, Weijun Wang wrote: >> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all >> current and future public and private keys. >> >> No test. Might add one. > > Weijun Wang has updated the pull request incrementally with one additional > commit

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v2]

2023-10-17 Thread Weijun Wang
> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all > current and future public and private keys. > > No test. Might add one. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: add spaces and code tags, and a test

Re: RFR: 8318096: Add getParams method in PublicKey and PrivateKey

2023-10-17 Thread Sean Mullan
On Tue, 17 Oct 2023 15:30:03 GMT, Weijun Wang wrote: > Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all > current and future public and private keys. > > No test. Might add one. src/java.base/share/classes/java/security/PrivateKey.java line 86: > 84: * The default